Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added destination fallback and conflict removal. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Controller/AuthController.php
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,14 @@ public function login(Request $request) {

$returnTo = $request->request->get('returnTo', $request->query->get('returnTo', NULL));

// If the 'destination' parameter is set, core will highjack our redirect.
// Unset it if it exists, and fall back to using it if no 'returnTo' is set.
$destination = $request->query->get('destination', NULL);
if ($destination) {
$request->query->remove('destination');
$returnTo = $returnTo ?? $destination;
}

// If supporting SSO, redirect to the hosted login page for authorization.
if ($this->redirectForSso) {
return new TrustedRedirectResponse($this->buildAuthorizeUrl(NULL, $returnTo));
Expand Down