Make downloading of books multithreaded, controlled via -j/--jobs #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildmichael
force-pushed
the
feature/parallel-downloads
branch
from
2a8f846 to
2b5b76f
Compare
added 2 commits
May 10, 2020 16:13
wildmichael
force-pushed
the
feature/parallel-downloads
branch
from
2b5b76f to
7ae9db2
Compare
|
Hi @wildmichael great work here! But for the sake of simplicity (and to not over demand springer servers), I prefer to leave the code single threaded. Thanks, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple (unscientific) timing: I downloaded the 10 first German books with
-j 1and-j 4:Single-threaded: 7m48s
Four threads: 2m41s
This is a factor of 2.9 faster.