fix: fix a bug with diameter input on edit planet

alevidals · Apr 8, 2024 · 33fea1a · 33fea1a
1 parent ff2345e
commit 33fea1a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/components/planets/edit-planet-form.tsx b/src/components/planets/edit-planet-form.tsx
@@ -32,7 +32,7 @@ export function EditPlanetForm(props: Props) {
     resolver: zodResolver(updatePlanetSchema),
     defaultValues: {
       name: planet.name,
-      diameter: planet.diameter,
+      diameter: String(planet.diameter),
       climates: planet.climates,
       terrains: planet.terrains,
       residents: planet.residents,
@@ -68,6 +68,7 @@ export function EditPlanetForm(props: Props) {
     const newPlanet: Planet = {
       ...planet,
       ...data,
+      diameter: Number(data.diameter),
       residents: data.residents.map((resident) => ({
         id: resident.id || Math.random().toString(),
         name: resident.name,
@@ -114,13 +115,7 @@ export function EditPlanetForm(props: Props) {
             <FormItem>
               <FormLabel>Diameter</FormLabel>
               <FormControl>
-                <Input
-                  type="number"
-                  {...field}
-                  onChange={(event) =>
-                    field.onChange(Number(event.target.value))
-                  }
-                />
+                <Input type="number" {...field} />
               </FormControl>
               <FormMessage />
             </FormItem>

diff --git a/src/lib/schemas.ts b/src/lib/schemas.ts
@@ -44,9 +44,14 @@ export const updatePlanetSchema = z.object({
   name: z.string().min(1, {
     message: "Name is required",
   }),
-  diameter: z.number().min(1, {
-    message: "Diameter is required",
-  }),
+  diameter: z
+    .string()
+    .min(1, {
+      message: "Diameter is required",
+    })
+    .refine((value) => !Number.isNaN(value) && Number(value) > 0, {
+      message: "Diameter must be a number greater than 0",
+    }),
   climates: z
     .array(
       z.object({