Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Disable Folded plot if there is no period #251

Closed
wants to merge 4 commits into from
Closed

Fix: Disable Folded plot if there is no period #251

wants to merge 4 commits into from

Conversation

HectorxH
Copy link
Contributor

@HectorxH HectorxH commented Dec 7, 2023

Summary of the changes

Update the lightcurve htmx component to disable the Folded plot when there is no period feature for the object.

Observations

Closes #249

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

@HectorxH HectorxH self-assigned this Dec 7, 2023
@HectorxH HectorxH linked an issue Dec 7, 2023 that may be closed by this pull request
[BUG] App crashes when trying to obtain Period #249
Open
dirodriguezm
dirodriguezm requested changes Dec 10, 2023
View reviewed changes
lightcurve/src/api/routes/htmx.py Outdated Show resolved Hide resolved
@dirodriguezm
Copy link
Contributor

Este ya se solucionó en otro commit

@HectorxH HectorxH deleted the 249-bug-app-crashes-when-trying-to-obtain-period branch October 22, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirodriguezm dirodriguezm dirodriguezm requested changes

@pgallardor pgallardor Awaiting requested review from pgallardor

Assignees

@HectorxH HectorxH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] App crashes when trying to obtain Period
2 participants
@HectorxH @dirodriguezm