Skip to content

Commit

Permalink
Merge pull request #61 from alercebroker/develop
Browse files Browse the repository at this point in the history
Merge Develop into Main
  • Loading branch information
HectorxH authored Nov 25, 2024
2 parents a485277 + a133423 commit ae15c8c
Show file tree
Hide file tree
Showing 36 changed files with 2,220 additions and 1,140 deletions.
880 changes: 725 additions & 155 deletions package-lock.json

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,17 @@
"test:unit": "vue-cli-service test:unit",
"lint": "vue-cli-service lint",
"prettier": "prettier --check .",
"prettier_write": "prettier --write .",
"deploy": "vue-cli-service s3-deploy",
"test": "jest"
},
"dependencies": {
"@mdi/font": "^5.9.55",
"axios": "^0.21.1",
"core-js": "^3.6.5",
"htmx.org": "^1.9.12",
"inversify-props": "^2.2.6",
"jsdom": "^24.1.0",
"moment": "^2.29.1",
"neverthrow": "^4.2.1",
"papaparse": "5.3.1",
Expand All @@ -29,6 +32,7 @@
},
"devDependencies": {
"@types/jest": "^24.9.1",
"@types/jsdom": "^21.1.7",
"@types/papaparse": "5.2.6",
"@typescript-eslint/eslint-plugin": "^4.18.0",
"@typescript-eslint/parser": "^4.18.0",
Expand All @@ -55,4 +59,4 @@
"vue-template-compiler": "^2.6.11",
"vuetify-loader": "^1.7.0"
}
}
}
2 changes: 1 addition & 1 deletion src/app/filter/domain/Filter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class WatchlistFilter implements IWatchlistFilter {
for (let i = 0; i < _steps.length; i++) {
const fields_set: Set<Field> = new Set();
fieldsList.forEach((fields) => {
fields[_steps[i]]!.forEach((field) => fields_set.add(field));
fields[_steps[i]]!.forEach((field) => fields_set.add(field));

Check warning on line 33 in src/app/filter/domain/Filter.ts

View workflow job for this annotation

GitHub Actions / publish

Forbidden non-null assertion
});
result[_steps[i]] = Array.from(fields_set);
}
Expand Down
10 changes: 6 additions & 4 deletions src/app/target/infrastructure/__tests__/TargetService.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ import {
ITargetRepository,
} from "../../domain/Target.types";

import { IWatchlistFilter, IWatchlistSingleFilter } from "@/app/filter/domain/Filter.types";
import {
IWatchlistFilter,
IWatchlistSingleFilter,
} from "@/app/filter/domain/Filter.types";
import { FilterFields } from "@/app/filter/domain/Filter";

const targetArray: ITargetData[] = [
Expand Down Expand Up @@ -95,10 +98,9 @@ export class MockTargetService implements ITargetRepository {
dec: 20,
radius: 30,
filter: {
fields:{} as FilterFields,
filters:[] as IWatchlistSingleFilter[]
fields: {} as FilterFields,
filters: [] as IWatchlistSingleFilter[],
},

} as ITargetData)
);
});
Expand Down
9 changes: 4 additions & 5 deletions src/shared/http/HttpService.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
import { IWatchlistSingleFilter } from "@/app/filter/domain/Filter.types";
import { FilterFields } from "@/app/filter/domain/Filter";


export type TestActions =
| "ok"
| "error"
Expand Down Expand Up @@ -111,8 +110,8 @@ export class MockUserApi extends HttpService {
ra: 0.960746,
dec: -11.47467,
filter: {
fields:{} as FilterFields,
filters:[] as IWatchlistSingleFilter[]
fields: {} as FilterFields,
filters: [] as IWatchlistSingleFilter[],
},
};
return [200, JSON.stringify(response)];
Expand All @@ -125,8 +124,8 @@ export class MockUserApi extends HttpService {
ra: 0.960746,
dec: -11.47467,
filter: {
fields:{} as FilterFields,
filters:[] as IWatchlistSingleFilter[]
fields: {} as FilterFields,
filters: [] as IWatchlistSingleFilter[],
},
};
return [201, JSON.stringify(response)];
Expand Down
1 change: 0 additions & 1 deletion src/shared/types/filter.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export interface WatchlistFilter {
}[];
}


// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface FilterParams {}

Expand Down
164 changes: 0 additions & 164 deletions src/ui/components/users/__tests__/Login.spec.ts

This file was deleted.

Loading

0 comments on commit ae15c8c

Please sign in to comment.