Skip to content

Fix: Applied some code review suggestions

Codecov / codecov/project failed Dec 9, 2024 in 1s

62.68% (-0.11%) compared to fb379ff

View this Pull Request on Codecov

62.68% (-0.11%) compared to fb379ff

Details

Codecov Report

Attention: Patch coverage is 55.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 62.68%. Comparing base (fb379ff) to head (70b7390).

Files with missing lines Patch % Lines
src/aleph/vm/models.py 45.83% 13 Missing ⚠️
src/aleph/vm/pool.py 20.00% 12 Missing ⚠️
src/aleph/vm/orchestrator/tasks.py 14.28% 6 Missing ⚠️
src/aleph/vm/hypervisors/qemu/qemuvm.py 86.66% 1 Missing and 1 partial ⚠️
...c/aleph/vm/hypervisors/qemu_confidential/qemuvm.py 0.00% 2 Missing ⚠️
src/aleph/vm/orchestrator/chain.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                    @@
##           proto-add-gpu-listing     #728      +/-   ##
=========================================================
- Coverage                  62.79%   62.68%   -0.11%     
=========================================================
  Files                         72       72              
  Lines                       6343     6403      +60     
  Branches                     514      524      +10     
=========================================================
+ Hits                        3983     4014      +31     
- Misses                      2199     2227      +28     
- Partials                     161      162       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov