Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve CI compiling issue #727

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Dec 3, 2024

Explain what problem this PR is resolving

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Solved CI issue creating the compiled package adding a fixed dependency for the protobuf package to the latest stable one.

How to test

Try to compile the project and see if it works well.

@nesitor nesitor requested a review from Antonyjin December 3, 2024 12:56
@nesitor nesitor self-assigned this Dec 3, 2024
@nesitor nesitor force-pushed the andres-fix-solve_protobuf_compiling_issue branch from 9b43483 to cd939c3 Compare December 3, 2024 12:58
@nesitor nesitor force-pushed the andres-fix-solve_protobuf_compiling_issue branch from cd939c3 to 544624a Compare December 3, 2024 13:03
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.50%. Comparing base (6836d6d) to head (544624a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   62.50%   62.50%           
=======================================
  Files          70       70           
  Lines        6232     6232           
  Branches      506      506           
=======================================
  Hits         3895     3895           
  Misses       2179     2179           
  Partials      158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Antonyjin Antonyjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nesitor nesitor merged commit 0241c04 into main Dec 3, 2024
22 checks passed
@nesitor nesitor deleted the andres-fix-solve_protobuf_compiling_issue branch December 3, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants