-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json logs endpoint which works for finished execution #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olethanh
force-pushed
the
ol-ALEPH-275-info-program-boot
branch
from
November 5, 2024 14:15
33b3b89
to
60b416d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
- Coverage 62.56% 62.50% -0.07%
==========================================
Files 70 70
Lines 6235 6232 -3
Branches 503 506 +3
==========================================
- Hits 3901 3895 -6
+ Misses 2181 2179 -2
- Partials 153 158 +5 ☔ View full report in Codecov by Sentry. |
olethanh
changed the title
Add json logs endpoint which allow for past record
Add json logs endpoint which works for finished execution
Nov 5, 2024
olethanh
force-pushed
the
ol-ALEPH-275-info-program-boot
branch
from
November 8, 2024 14:17
3f29f1d
to
b887add
Compare
nesitor
reviewed
Nov 18, 2024
olethanh
force-pushed
the
ol-ALEPH-275-info-program-boot
branch
4 times, most recently
from
November 20, 2024 09:06
c3140c5
to
bff9d52
Compare
olethanh
force-pushed
the
ol-ALEPH-275-info-program-boot
branch
from
November 24, 2024 16:42
bff9d52
to
841fd1a
Compare
nesitor
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a endpoint to get log from program from history, even after they have run.
Related ClickUp, GitHub or Jira tickets : ALEPH-275
Related Client PR aleph-im/aleph-client#304
Self proofreading checklist
Changes
add
/control/machine/{ref}/logs.json
How to test
Use the related branch in the client
ol-ALEPH-275-info-program-boot
or check the unit test. You can also call the endpoint by hand