Fix: Error fetching message from vm-connector for start_watch_for_messages_task #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
==========================================
+ Coverage 62.45% 62.49% +0.04%
==========================================
Files 69 69
Lines 6139 6135 -4
Branches 645 644 -1
==========================================
Hits 3834 3834
+ Misses 2153 2149 -4
Partials 152 152 ☔ View full report in Codecov by Sentry. |
…sages_task Jira ticket : ALEPH-111 Problem: When aleph-vm was starting if the vm-connector couldn't connect to the pyaleph API , the startup crashed and systemd restarted it in a loop. Solution: Stop registering the sample program at startup, so the pyaleph api don't need to be reached at startup. This code was left as a demo but it didn't really do anything at the moment. We have just commented the code if we want to reuse it in the future. Note: A more complete and long analysis of the problem, along with propsed solution is on the JIRA ticket https://aleph-im.atlassian.net/browse/ALEPH-111?focusedCommentId=10008
nesitor
force-pushed
the
ol-aleph-111-error-fetching-message-at-start
branch
from
1a56dff to
55752b2
Compare
nesitor
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When aleph-vm was starting if the vm-connector couldn't connect to the pyaleph API , the startup crashed and systemd restarted it in a loop.
Solution:
Stop registering the sample program at startup, so the pyaleph api don't need to be reached at startup. This code was left as a demo but it didn't really do anything at the moment.
We have just commented the code if we want to reuse it in the future.
Jira ticket : ALEPH-111
Self proofreading checklist
Changes
How to test
stop your pyaleph and restart aleph-vm
Print screen / video
Notes
A more complete and long analysis of the problem, along with different proposed solution is in the comment of the JIRA ticket
https://aleph-im.atlassian.net/browse/ALEPH-111?focusedCommentId=10008