-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: Websocket were required to fetch logs #645
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 59.94% 61.25% +1.30%
==========================================
Files 64 65 +1
Lines 5458 5603 +145
Branches 592 596 +4
==========================================
+ Hits 3272 3432 +160
+ Misses 2043 2023 -20
- Partials 143 148 +5 ☔ View full report in Codecov by Sentry. |
1fe5861
to
d0bde95
Compare
Solution: Provide a view that works in get not sure about the endpoint name. It's just a proposal to see if it is interesting to have it Still have to fix the style and doc but want to gather your feed back first
d0bde95
to
c74d9c0
Compare
c74d9c0
to
2ac23fb
Compare
I have renamed the endpoint as suggested and added tests for them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat code. I added two nitpicks, but good overall.
I see a test failing however.
Solution: Provide a view that works in get
not sure about the endpoint name.
It's just a proposal to see if it is interesting to have it Still have to fix the style and doc but want to gather your feed back first