Skip to content

Commit

Permalink
Fix options for HostVolume
Browse files Browse the repository at this point in the history
  • Loading branch information
olethanh committed Jun 25, 2024
1 parent cf801e0 commit f4653a4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/aleph/vm/hypervisors/qemu/qemuvm.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ async def start(
for volume in self.host_volumes:
args += [
"-drive",
f"file={volume.path_on_host},format=raw,readonly={'on' if volume.read_only else 'off'}",
f"file={volume.path_on_host},format=raw,readonly={'on' if volume.read_only else 'off'},media=disk,if=virtio",
]
if self.interface_name:
# script=no, downscript=no tell qemu not to try to set up the network itself
Expand Down
2 changes: 1 addition & 1 deletion src/aleph/vm/hypervisors/qemu_confidential/qemuvm.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ async def start(
for volume in self.host_volumes:
args += [

Check warning on line 110 in src/aleph/vm/hypervisors/qemu_confidential/qemuvm.py

View check run for this annotation

Codecov / codecov/patch

src/aleph/vm/hypervisors/qemu_confidential/qemuvm.py#L110

Added line #L110 was not covered by tests
"-drive",
f"file={volume.path_on_host},format=raw,readonly={'on' if volume.read_only else 'off'}",
f"file={volume.path_on_host},format=raw,readonly={'on' if volume.read_only else 'off'},media=disk,if=virtio",
]
if self.interface_name:
# script=no, downscript=no tell qemu not to try to set up the network itself
Expand Down

0 comments on commit f4653a4

Please sign in to comment.