Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs on aleph node cmds + sanitize_url + missing tests #329

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

philogicae
Copy link
Member

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

@philogicae philogicae requested review from olethanh and aliel January 23, 2025 14:32
@philogicae philogicae self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.02%. Comparing base (cdf4aab) to head (2105fb9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/node.py 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   54.46%   57.02%   +2.55%     
==========================================
  Files          18       18              
  Lines        2585     2592       +7     
  Branches      326      330       +4     
==========================================
+ Hits         1408     1478      +70     
+ Misses       1009      939      -70     
- Partials      168      175       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Failed to retrieve llama text: POST 500: 500: Unhandled error during initialisation

@philogicae philogicae changed the title Fix bugs on aleph node commands + sanitize_url Fix bugs on aleph node cmds + sanitize_url + missing tests Jan 23, 2025
@philogicae philogicae force-pushed the fix-aleph-node-commands branch from 11c8d62 to 2105fb9 Compare January 23, 2025 15:03
@philogicae philogicae merged commit d3e710e into master Jan 23, 2025
16 checks passed
@philogicae philogicae deleted the fix-aleph-node-commands branch January 23, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants