feat(capture): show output progress during capture #41
+51
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessio Greggi <[email protected]>
Signed-off-by: Alessio Greggi <[email protected]>
ccoVeille
reviewed
Aug 28, 2024
cmd/hunt.go
Outdated
| @@ -95,6 +95,7 @@ func init() { | |||
| huntCmd.MarkFlagRequired("file") | |||
|
|
|||
| huntCmd.Flags().BoolVarP(&commandOutput, "include-cmd-output", "c", false, "Include the executed command output") | |||
| huntCmd.Flags().BoolVarP(&commandError, "include-cmd-error", "e", false, "Include the executed command error") | |||
There was a problem hiding this comment.
Suggested change
| huntCmd.Flags().BoolVarP(&commandError, "include-cmd-error", "e", false, "Include the executed command error") | |
| huntCmd.Flags().BoolVarP(&commandError, "include-cmd-stderr", "e", false, "Include the executed command error") |
Suggested change
| huntCmd.Flags().BoolVarP(&commandError, "include-cmd-error", "e", false, "Include the executed command error") | |
| huntCmd.Flags().BoolVarP(&commandError, "include-cmd-errors", "e", false, "Include the executed command error") |
There was a problem hiding this comment.
We might change also the include-cmd-output to include-cmd-stdout to be consistent
There was a problem hiding this comment.
I committed the wrong option 😅
Could you add the commit suggestion again? The one with stderr I mean
There was a problem hiding this comment.
You can simply edit locally
Co-authored-by: ccoVeille <[email protected]>
alegrey91
changed the title
Signed-off-by: Alessio Greggi <[email protected]>
ccoVeille
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40