feat: add group participants #132
Conversation
WalkthroughThis update introduces significant enhancements to group management capabilities within the API, including new endpoints for creating groups and managing participants. The changes streamline group operations such as adding, removing, promoting, and demoting participants. Additionally, the documentation and codebase reflect these advancements, ensuring developers can effectively utilize the new features. This version also includes minor adjustments for improved functionality and user experience. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (10)
Files skipped from review due to trivial changes (2)
Additional comments not posted (19)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| err := c.BodyParser(&request) | ||
| utils.PanicIfNeeded(err) | ||
|
|
||
| whatsapp.SanitizePhone(&request.GroupID) |
There was a problem hiding this comment.
Sanitize GroupID to prevent injection attacks.
- whatsapp.SanitizePhone(&request.GroupID)
+ sanitizedGroupID, err := whatsapp.SanitizeGroupID(request.GroupID)
+ if err != nil {
+ return c.Status(fiber.StatusBadRequest).JSON(utils.ResponseError{Message: "Invalid Group ID"})
+ }
+ request.GroupID = sanitizedGroupIDEnsure that GroupID is properly sanitized to prevent potential injection attacks. Consider implementing a dedicated sanitization function if not already available.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| whatsapp.SanitizePhone(&request.GroupID) | |
| sanitizedGroupID, err := whatsapp.SanitizeGroupID(request.GroupID) | |
| if err != nil { | |
| return c.Status(fiber.StatusBadRequest).JSON(utils.ResponseError{Message: "Invalid Group ID"}) | |
| } | |
| request.GroupID = sanitizedGroupID |
| participantsJID, err := service.participantToJID(request.Participants) | ||
| if err != nil { | ||
| return |
There was a problem hiding this comment.
Handle errors explicitly in participantToJID calls.
- participantsJID, err := service.participantToJID(request.Participants)
- if err != nil {
- return
- }
+ participantsJID, err := service.participantToJID(request.Participants)
+ if err != nil {
+ return nil, err
+ }Ensure that errors returned by participantToJID are handled explicitly to avoid silent failures and improve error reporting.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| participantsJID, err := service.participantToJID(request.Participants) | |
| if err != nil { | |
| return | |
| participantsJID, err := service.participantToJID(request.Participants) | |
| if err != nil { | |
| return nil, err |
Context
Test Results