Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oauth working #1170

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: oauth working #1170

merged 1 commit into from
Nov 21, 2024

Conversation

RobChangCA
Copy link
Collaborator

@RobChangCA RobChangCA commented Nov 21, 2024

Pull Request Checklist


PR-Codex overview

This PR enhances the useNewUserSignup functionality by adding a condition to check for an initial signup state and whether the modal is open. It also modifies the logic to handle new user signups more effectively by introducing a new state variable.

Detailed summary

  • Updated useNewUserSignup invocation in modal.tsx to include additional conditions for authStep.type and isOpen.
  • Introduced a new state variable isNewUser in useNewUserSignup.
  • Adjusted the effect to listen for newUserSignup events and update isNewUser.
  • Refactored signup handling logic to trigger onSignup based on isNewUser state instead of a separate handler.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 6:03pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 6:03pm

Copy link

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@RobChangCA RobChangCA merged commit 196905d into main Nov 21, 2024
6 checks passed
@RobChangCA RobChangCA deleted the rob/oauthfix branch November 21, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants