-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oauth add passkey after signup (popup flow) #1151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependencies change
Co-authored-by: Michael Moldoveanu <[email protected]>
moldy530
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to update the ui-demo app to default back to using pop-up now?
moldy530
reviewed
Nov 14, 2024
moldy530
reviewed
Nov 14, 2024
Co-authored-by: Michael Moldoveanu <[email protected]>
linnall
requested review from
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
November 14, 2024 23:09
moldy530
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR introduces a new user signup event in the
AlchemySigner
and updates various components to handle this event, alongside some refactoring in theuseAuthModal
and related hooks.Detailed summary
newUserSignup
event toAlchemySignerClientEvents
.newUserSignup
on successful user signup inAlchemySignerWebClient
.closeAuthModal
inuseAuthModal
to improve readability.CompletingOAuth
to simplify auth step setting.AuthModal
to handle signup logic withuseNewUserSignup
.