Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oauth add passkey after signup (popup flow) #1151

Merged
merged 46 commits into from
Nov 15, 2024

Conversation

linnall
Copy link
Collaborator

@linnall linnall commented Nov 13, 2024

Pull Request Checklist


PR-Codex overview

This PR introduces a new user signup event in the AlchemySigner and updates various components to handle this event, alongside some refactoring in the useAuthModal and related hooks.

Detailed summary

  • Added newUserSignup event to AlchemySignerClientEvents.
  • Emitted newUserSignup on successful user signup in AlchemySignerWebClient.
  • Refactored closeAuthModal in useAuthModal to improve readability.
  • Updated CompletingOAuth to simplify auth step setting.
  • Adjusted AuthModal to handle signup logic with useNewUserSignup.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linnall and others added 30 commits October 30, 2024 16:45
Co-authored-by: Michael Moldoveanu <[email protected]>
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update the ui-demo app to default back to using pop-up now?

account-kit/signer/src/client/types.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Moldoveanu <[email protected]>
@linnall
Copy link
Collaborator Author

linnall commented Nov 15, 2024

do we need to update the ui-demo app to default back to using pop-up now?

done in #1140 before merging (here and here)

@linnall linnall merged commit 844a481 into main Nov 15, 2024
6 checks passed
@linnall linnall deleted the linna/oauth-add-passkey-popup branch November 15, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants