fix: add check to ensure WC indexedDB store had been previously initialized on disconnect

[iykazrji]

Pull Request Checklist

• Did you add new tests and confirm existing tests pass? (yarn test)
• Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
• Do your commits follow the Conventional Commits standard?
• Does your PR title also follow the Conventional Commits standard?
• If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
• Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
• Did you follow the contribution guidelines?

---

PR-Codex overview

This PR focuses on enhancing the clearWalletConnectStore function to handle the scenario where the WALLET_CONNECT_V2_INDEXED_DB may not exist, ensuring the database is deleted if it is outdated.

Detailed summary

• Added a check for walletConnectDBExists to determine if the database exists.
• Implemented an onupgradeneeded event to delete the database if the version is outdated.
• Wrapped the database operations in a try-catch block to handle errors gracefully.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aa-sdk-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2024 6:15pm
aa-sdk-ui-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2024 6:15pm

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[moldy530]

we should probably start with the assumption that it isn't initialized

[iykazrji]

Sure! Would update to reflect this

[iykazrji]

Actually on further testing, it is better we start with the assumption that it is in fact initialized. This is because dbRequest.onUpgradeneeded() isn't actually called on every request, only when there is a DB version change. This means when we call disconnect() after walletConnect has created the IDB store, we wouldn't be running that event handler, and thus if we default to false, we wouldn't have a way to change the value to true.

[moldy530]

wouldn't this throw if this state means it's not connected?

[iykazrji]

Actually, by this point the DB would actually already have been created by the previous indexedDB.open() call made above. It's the behaviour for IDB to create a database if it doesn't exist when we call indexedDB.open(). So it actually wouldn't throw in this case

[moldy530]

I see, so lemme run this back to see if I understand

db.open will create a db if it doesn't exist or open the existing one if it does.

if it doesn't exist and thus gets created, that fires the upgrade event here. We know it was created because version is 1 indexed (not 0 indexed?)

Since this only gets called on disconnect, there's no risk that this gets fired when WC first creates the db

[moldy530]

do we need to do any other checks here? does indexDb.open ever throw?

[iykazrji]

Yeah, but we're already handling the error case for that with the dbOpenRequest.onerror() handler below

[moldy530]

LGTM, other sanity check - we don't need to remove the handlers right? they only get attached to this specific open request, not globally? Wanna make sure that, if you call disconnect (previously logged in as email) and then try to connect with WC for the first time, then you won't end up in a state where this handler deletes the DB because this handler is still registered

[iykazrji]

Yes! The handlers are only attached to this dbOpenRequest called only when the disconnect() call happens.