Skip to content

Commit

Permalink
Fix minimap toggle visibility (wagtail#12279)
Browse files Browse the repository at this point in the history
Co-authored-by: Thibaud Colas <[email protected]>
  • Loading branch information
albinazs and thibaudcolas authored Sep 24, 2024
1 parent c2b35b8 commit 722b79d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 25 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Changelog
* Fix: Remove wrongly-added filters from redirects index (Matt Westcott)
* Fix: Prevent popular tags filter from generating overly complex queries when not filtering (Matt Westcott)
* Fix: Fix content path links in usage view to scroll to the correct element (Sage Abdullah)
* Fix: Always show the minimap toggle button (Albina Starykova)
* Docs: Upgrade Sphinx to 7.3 (Matt Westcott)
* Docs: Document how to customize date/time format settings (Vince Salvino)
* Docs: Create a new documentation section for deployment and move fly.io deployment from the tutorial to this section (Vince Salvino)
Expand Down
4 changes: 2 additions & 2 deletions client/src/components/Minimap/CollapseAll.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
position: absolute;
top: $minimap-top-offset;
inset-inline-end: 0;
margin-top: theme('spacing.3');
margin-inline-end: theme('spacing.3');
margin-top: theme('spacing.5');
margin-inline-end: theme('spacing.10');

.side-panel-open & {
inset-inline-end: var(--side-panel-width, 0);
Expand Down
24 changes: 1 addition & 23 deletions client/src/components/Minimap/Minimap.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,30 +53,10 @@ $minimap-z-index: calc(theme('zIndex.header') - 20);
background-color: theme('colors.surface-page');
color: theme('colors.icon-primary');
transform: rotate(180deg);
// Expand is available for keyboard users only.
opacity: 0;
pointer-events: none;

@include media-breakpoint-up(sm) {
margin-top: theme('spacing.9');
margin-top: 18px;
padding: theme('spacing.[1.5]');

*:focus {
opacity: 1;
pointer-events: auto;
}

// Ensure the toggle button is only visible when it has **focus-visible**.
// With fallback focus styles for browsers that lack focus-visible support.
*:focus:not(:focus-visible) {
opacity: 0;
pointer-events: none;
}

&:focus-visible {
opacity: 1;
pointer-events: auto;
}
}

.icon {
Expand All @@ -85,8 +65,6 @@ $minimap-z-index: calc(theme('zIndex.header') - 20);
}

:where(.w-minimap--expanded) & {
opacity: 1;
pointer-events: auto;
margin-top: theme('spacing.3');
margin-inline-start: theme('spacing.3');
padding: theme('spacing.3');
Expand Down
1 change: 1 addition & 0 deletions docs/releases/6.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ This release adds formal support for Django 5.1.
* Remove wrongly-added filters from redirects index (Matt Westcott)
* Prevent popular tags filter from generating overly complex queries when not filtering (Matt Westcott)
* Fix content path links in usage view to scroll to the correct element (Sage Abdullah)
* Always show the minimap toggle button (Albina Starykova)

### Documentation

Expand Down

0 comments on commit 722b79d

Please sign in to comment.