Better handling of timepicker (issue #24) #25
Conversation
|
Thanks for your contribution! |
| format.gsub(/#{DATE_FORMAT_REPLACEMENTS.keys.join("|")}/) { |match| DATE_FORMAT_REPLACEMENTS[match] } | ||
| end | ||
|
|
||
| def translate_time_format(format) |
There was a problem hiding this comment.
I would pass a parameter instead having two methods doing the same
|
OK done :) Would be great to add some tests as well. If you don't want to fix these things, let me know and I'll Pull request to your fork. Regards. |
|
I've fixed the issues you mentioned and the tests all pass now. However, I'm not sure what tests to write for the timepicker features. You are welcome to write tests yourself if you want to. Best, |
|
Any chance this can be merged and released? |
|
Hi! Any news on this? Would you like some help merging this? |
|
I sent a Pull Request to @AlexNisnevich, rebasing the code and adding some tests. As soon as that is merged, I'll merge this Pull Request as well. |
|
Thanks! Unfortunately, I'm on vacation now and unable to look at this, but I will merge the pull request next week. |
|
Ok, I've merged your pull request. |
|
I've just installed the gem, and implemented it using the view helpers and now when I run rails s I'm getting the following: /usr/local/rvm/gems/ruby-2.0.0-p247/gems/jquery_datepicker-0.4/lib/app/helpers/form_helper.rb:33:in `<top (required)>': uninitialized constant ActionView::Helpers::InstanceTag (NameError) |
I implemented the two features I wanted in issue #24 . Feel free to do whatever you wish with this code.