Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 2024-08-10 #1031

Merged
merged 2 commits into from
Aug 11, 2024
Merged

chore: release 2024-08-10 #1031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac9eb97
build: pre-commit autoupdate (#1011)
pre-commit-ci[bot] Jul 20, 2024
74f2986
fix: fix api proxy cert blocking the event loop (#1030)
bdraco Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions custom_components/tesla_custom/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,17 @@
# Because users can have multiple accounts, we always
# create a new session so they have separate cookies

if config.get(CONF_API_PROXY_CERT):
if api_proxy_cert := config.get(CONF_API_PROXY_CERT):
try:
SSL_CONTEXT.load_verify_locations(config[CONF_API_PROXY_CERT])
_LOGGER.debug("Trusting CA: %s", SSL_CONTEXT.get_ca_certs()[-1])
await hass.async_add_executor_job(
SSL_CONTEXT.load_verify_locations, api_proxy_cert
)
if _LOGGER.isEnabledFor(logging.DEBUG):
_LOGGER.debug("Trusting CA: %s", SSL_CONTEXT.get_ca_certs()[-1])
except (FileNotFoundError, ssl.SSLError):
_LOGGER.warning(
"Unable to load custom SSL certificate from %s",
config[CONF_API_PROXY_CERT],
api_proxy_cert,

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (certificate)
Loading
as clear text.
)

async_client = httpx.AsyncClient(
Expand Down Expand Up @@ -181,7 +184,6 @@
polling_policy=config_entry.options.get(
CONF_POLLING_POLICY, DEFAULT_POLLING_POLICY
),
api_proxy_cert=config.get(CONF_API_PROXY_CERT),
api_proxy_url=config.get(CONF_API_PROXY_URL),
client_id=config.get(CONF_CLIENT_ID),
)
Expand Down
Loading