Minor fix

- Fixed queues not being disposed
alandoherty · Dec 17, 2018 · 9d42fd3 · 9d42fd3
1 parent d3bc8e3
commit 9d42fd3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 15 deletions.
diff --git a/samples/Example.General/Program.cs b/samples/Example.General/Program.cs
@@ -77,16 +77,9 @@ static async Task AsyncMain(string[] args) {
             });
 
             // attach
-            //await TestNode.AttachAsync("auth:login", RpcBehaviour.Bind<ITest001>(new Test001(Guid.NewGuid())));
-
-            // subscribe
-            (await TestNode.SubscribeAsync("auth:login.happened"))
-                .AsObservable().Subscribe(new EventObserver());
-
-            await TestNode.EmitAsync("auth:login.happened", new LoginRequestMsg() {
-                Password = "password",
-                Username = "username"
-            }).ConfigureAwait(false);
+            Service service = await TestNode.AttachAsync("auth:login", RpcBehaviour.Bind<ITest001>(new Test001(Guid.NewGuid())));
+
+            service.Dispose();
 
             await Task.Delay(50000);
         }

diff --git a/src/Holon/Holon.csproj b/src/Holon/Holon.csproj
@@ -2,19 +2,19 @@
 
   <PropertyGroup>
     <TargetFramework>netstandard1.6</TargetFramework>
-    <Version>0.1.6.3</Version>
+    <Version>0.1.7</Version>
     <Authors>Alan Doherty</Authors>
     <Company>Alan Doherty</Company>
     <Description>A minimal service and event bus with additional support for RPC</Description>
     <Copyright>BattleCrate Ltd 2018</Copyright>
     <PackageProjectUrl>https://github.com/alandoherty/holon-net</PackageProjectUrl>
     <RepositoryUrl>https://github.com/alandoherty/holon-net</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
-    <AssemblyVersion>0.1.6.3</AssemblyVersion>
+    <AssemblyVersion>0.1.7.0</AssemblyVersion>
     <PackageLicenseUrl>https://github.com/alandoherty/holon-net/blob/master/LICENSE</PackageLicenseUrl>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageIconUrl>https://s3-eu-west-1.amazonaws.com/assets.alandoherty.co.uk/github/holon-net-nuget.png</PackageIconUrl>
-    <FileVersion>0.1.6.3</FileVersion>
+    <FileVersion>0.1.7.0</FileVersion>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">

diff --git a/src/Holon/Services/Service.cs b/src/Holon/Services/Service.cs
@@ -294,11 +294,9 @@ private async Task ServiceHandleAsync(Envelope envelope) {
         }
 
         void IObserver<InboundMessage>.OnCompleted() {
-            throw new NotImplementedException();
         }
 
         void IObserver<InboundMessage>.OnError(Exception error) {
-            throw new NotImplementedException();
         }
 
         async void IObserver<InboundMessage>.OnNext(InboundMessage message) {