feat: add setting for estimating time ranges using bucket count queries #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Jan 16, 2025
| @@ -307,11 +307,16 @@ private[r2dbc] class PostgresDurableStateDao(executorProvider: R2dbcExecutorProv | |||
| else | |||
| "SELECT persistence_id, revision, db_timestamp, CURRENT_TIMESTAMP AS read_db_timestamp, state_ser_id, state_ser_manifest, state_payload " | |||
|
|
|||
| val sliceFilter = { | |||
| if (settings.querySettings.estimateTimeRange) sliceCondition(minSlice, maxSlice) | |||
| else s"slice BETWEEN $minSlice AND $maxSlice" | |||
There was a problem hiding this comment.
for reference, it was changed to IN instead of BETWEEN in #249
but it can be different with the new index
There was a problem hiding this comment.
Yes, with the new index the IN becomes a separate filter rather than an index scan condition. Not sure if we should base this switch on the estimate-time-range setting, or have a separate setting or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it possible to disable the bucket count queries, to use alternative indexes for the by-slice queries.