Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the download function from AssetMediaFileApiInterface #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace the download function from AssetMediaFileApiInterface #235

wants to merge 1 commit into from

Conversation

Rud5G
Copy link

@Rud5G Rud5G commented Jun 10, 2022

by extending the interface with DownloadableResourceInterface

Replace the download function from AssetMediaFileApiInterface
163c7ab 
by extending the interface with DownloadableResourceInterface
@LevFlavien
Copy link
Contributor

Hi @Rud5G

Thank you for your contribution. In order to contribute to Akeneo projects, we would like you to sign the CLA.
Could you also please push again once so the circleCI hook can be triggered? if it doesn't work I'll duplicate the PR in order to run tests.

@LevFlavien LevFlavien self-requested a review June 14, 2022 16:13
@tomglvng
Copy link
Collaborator

tomglvng commented Jun 6, 2023

Hi @Rud5G,
Thanks for your contribution! We would like to merge it. For doing that, we need your agreement in our Contributor License Agreement (https://www.akeneo.com/contributor-license-agreement/).
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LevFlavien LevFlavien Awaiting requested review from LevFlavien

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rud5G @LevFlavien @tomglvng