Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(observability): utilise new logger in indexer #522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(observability): utilise new logger in indexer #522

wants to merge 1 commit into from

Conversation

forbesus
Copy link
Contributor

@forbesus forbesus commented Dec 5, 2024

ref #434

@forbesus forbesus requested a review from a team as a code owner December 5, 2024 12:06
ygrishajev
ygrishajev reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ygrishajev ygrishajev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the browser all of the logs were debug coz we need no logs when it's served to a user, only during development. Here all the logs should have relevant log level.

apps/indexer/src/chain/chainSync.ts Outdated Show resolved Hide resolved
@forbesus forbesus force-pushed the feature/new-logger-indexer branch from ef9d923 to 8b4a382 Compare December 9, 2024 12:40
@forbesus
Copy link
Contributor Author

Would you check this? @ygrishajev

@forbesus forbesus requested a review from ygrishajev December 10, 2024 20:30
ygrishajev
ygrishajev reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ygrishajev ygrishajev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Redm4x @max could one of you verify all the log levels used make sense pls?

apps/indexer/src/chain/dataStore.ts Outdated Show resolved Hide resolved
apps/indexer/src/chain/chainSync.ts Outdated Show resolved Hide resolved
apps/indexer/src/index.ts Outdated Show resolved Hide resolved
@forbesus forbesus force-pushed the feature/new-logger-indexer branch from 8b4a382 to 9400dc9 Compare December 11, 2024 09:48
@forbesus
Copy link
Contributor Author

please check again @Redm4x @max @ygrishajev

@forbesus
Copy link
Contributor Author

@Redm4x @max could one of you verify all the log levels used make sense pls?

i think @baktun14 should check this
how about @ygrishajev ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygrishajev ygrishajev ygrishajev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forbesus @ygrishajev