Feature/config #396
Merged
Feature/config #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygrishajev
force-pushed
the
feature/config
branch
from
5c5a8ca to
ed8d1ba
Compare
baktun14
approved these changes
Oct 7, 2024
| const { | ||
| params: { address, dseq }, | ||
| searchParams: { network } | ||
| } = DeploymentDetailPageSchema.parse(props); |
There was a problem hiding this comment.
This will throw an error if the props are not correct?
There was a problem hiding this comment.
I think network id should have a default value of mainnet.
There was a problem hiding this comment.
so let's imagine someone implements a link to this page on the frontend. The one may notice that it works without the network params and not bother why it's needed. Thus we may get a bug when a mainnet link is opened from, say, staging.
I'd say it should fail in dev.
There was a problem hiding this comment.
I suppose yea, we do append the network param to the path everywhere is use it so it should be fine.
ygrishajev
force-pushed
the
feature/config
branch
from
ed8d1ba to
9182d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR commits are describing what's done. It's also a step-by-step guide to apply to provider-web