Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uptime checks for some providers #316

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix uptime checks for some providers #316

merged 2 commits into from
Aug 20, 2024

Conversation

Redm4x
Copy link
Contributor

@Redm4x Redm4x commented Aug 16, 2024

This PR changes the grpc client_idle_timeout_ms config to 5min to prevent an uptime check bug with some providers:

The issue causes uptime checks to fail at first and then succeed at the first retry. This affects the uptime percentage as it counts as multiple 1min downtime period.

While the exact root cause of this issue has not yet been identified, this prevents it for now. If we find a better fix later on we could revert it back to the default value.

@Redm4x Redm4x force-pushed the fix/grpc-idle-timeout branch 2 times, most recently from 9a9169a to 2700c8f Compare August 16, 2024 19:47
@Redm4x Redm4x force-pushed the fix/grpc-idle-timeout branch from 2700c8f to de4b9ef Compare August 16, 2024 20:03
@Redm4x Redm4x force-pushed the fix/grpc-idle-timeout branch from de4b9ef to 3954aaa Compare August 20, 2024 13:53
@Redm4x
Copy link
Contributor Author

Redm4x commented Aug 20, 2024

Changed it a bit to set the keepalive interval. Instead of closing the connection after 5min it will send pings to make sure the connection is still active.

grpc.keepalive_time_ms

@Redm4x Redm4x merged commit 303b11d into main Aug 20, 2024
5 checks passed
@Redm4x Redm4x deleted the fix/grpc-idle-timeout branch August 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants