fix(auth): properly authenticate new endpoints #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygrishajev
force-pushed
the
feature/errors
branch
from
34402e5 to
df288fd
Compare
ygrishajev
force-pushed
the
feature/auth
branch
from
c37e8ef to
bedc221
Compare
ygrishajev
force-pushed
the
feature/auth
branch
from
bedc221 to
396b25b
Compare
ygrishajev
commented
Aug 8, 2024
| @@ -43,4 +50,12 @@ export class AuthInterceptor implements HonoInterceptor { | |||
| return await next(); | |||
| }; | |||
| } | |||
|
|
|||
| private async getValidUserId(bearer: string, c: Context) { | |||
There was a problem hiding this comment.
I'd put this method into AuthTokenService but I don't want that one to depend on http context. And seems like this method needs that in any way. Any thoughts @Redm4x ?
ygrishajev
force-pushed
the
feature/auth
branch
from
396b25b to
82daae6
Compare
baktun14
approved these changes
Aug 9, 2024
ygrishajev
force-pushed
the
feature/auth
branch
from
82daae6 to
22f98f8
Compare
ygrishajev
force-pushed
the
feature/auth
branch
from
22f98f8 to
4131752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #247