Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet connect & sign arbitrary #268

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Wallet connect & sign arbitrary #268

merged 7 commits into from
Aug 7, 2024

Conversation

jigar-arc10
Copy link
Contributor

@jigar-arc10 jigar-arc10 commented Jul 12, 2024 •
edited
Loading

  • Wallet Connect
  • cosmos-kit integration
  • merge current praetor functionality to new wallet connect
  • store jwt for process API calls
  • public key storage for encrypting things in future

@jigar-arc10 jigar-arc10 marked this pull request as ready for review August 2, 2024 20:05
@jigar-arc10 jigar-arc10 marked this pull request as draft August 2, 2024 20:06
@jigar-arc10 jigar-arc10 marked this pull request as ready for review August 2, 2024 20:42
@jigar-arc10 jigar-arc10 assigned baktun14 and unassigned baktun14 Aug 5, 2024
@jigar-arc10 jigar-arc10 requested a review from baktun14 August 5, 2024 19:31
@anilmurty anilmurty mentioned this pull request Aug 6, 2024
Open
@jigar-arc10 jigar-arc10 changed the title wip - wallet connect init Wallet connect init Aug 6, 2024
@jigar-arc10 jigar-arc10 changed the title Wallet connect init Wallet connect & sign arbitrary Aug 6, 2024
baktun14
baktun14 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of code duplication with deploy Console. We should try and extract what can be re-used between both apps into the ui package or for type a new types package.

apps/provider-console/src/context/SettingsProvider/SettingsProviderContext.tsx
customNode: null
};

export const SettingsProvider: FC<{ children: ReactNode }> = ({ children }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure you guys need all the logic for custom nodes and list of nodes, but I guess it works without a ui to change it.

apps/provider-console/src/types/deployment.ts
@@ -0,0 +1,335 @@
export interface DeploymentDetail {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should extract all the types into a separate package

@jigar-arc10
Copy link
Contributor Author

There's a lot of code duplication with deploy Console. We should try and extract what can be re-used between both apps into the ui package or for type a new types package.

Let's plan the next phase for extraction and shared packages

@jigar-arc10 jigar-arc10 merged commit 06b5431 into main Aug 7, 2024
5 checks passed
@jigar-arc10 jigar-arc10 deleted the feature/provider-console/wallet-connect branch August 7, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baktun14 baktun14 baktun14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jigar-arc10 @baktun14