feat(billing): implement sign-tx endpoint #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygrishajev
force-pushed
the
feature/fiat-sign
branch
from
a89ee81 to
bf2acb9
Compare
baktun14
reviewed
Jul 10, 2024
baktun14
reviewed
Jul 18, 2024
apps/api/src/billing/services/managed-user-wallet/managed-user-wallet.service.ts
Outdated
Show resolved
Hide resolved
| <> | ||
| {user?.username && user?.bio && ( | ||
| <UserProfileLayout page="settings" username={user?.username} bio={user?.bio}> | ||
| {isLoading || !user ? ( |
There was a problem hiding this comment.
I guess we don't need to check user if the user has a username.
Suggested change
| {isLoading || !user ? ( | |
| {isLoading ? ( |
There was a problem hiding this comment.
ok, to handle cases like this added a container which would provide user guaranteed.
5487667
ygrishajev
force-pushed
the
feature/fiat-sign
branch
6 times, most recently
from
2b44094 to
8011159
Compare
baktun14
approved these changes
Jul 24, 2024
ygrishajev
force-pushed
the
feature/fiat-sign
branch
from
5487667 to
ae5f07e
Compare
As a part of this: - add drizzle orm to start migration from sequelize - add new top leve modules to start moving towards better modularity - add DI - cover new billing endpoints with functional tests - introduce proper logging - introduce global error handler refs #247
ygrishajev
force-pushed
the
feature/fiat-sign
branch
from
ae5f07e to
5def025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a part of this:
refs #247