style(dx): centralize code style tools #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygrishajev
force-pushed
the
feature/code-style
branch
from
8e124ea to
e69d8cd
Compare
This was referenced Jun 7, 2024
ygrishajev
force-pushed
the
feature/workspaces
branch
from
371acf2 to
78a647d
Compare
Redm4x
reviewed
Jun 7, 2024
ygrishajev
force-pushed
the
feature/code-style
branch
from
e69d8cd to
383da6d
Compare
ygrishajev
force-pushed
the
feature/code-style
branch
from
383da6d to
87f3293
Compare
Redm4x
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR centralizes the configurations of ESLint and Prettier under a shared package
dev-config. All the apps and packages within the monorepo now use these centralized configurations. Additionally, the root monorepo combines them to ensure consistency. This approach allows both linting and formatting to be used globally and within each app/package. Another benefit is that thisdev-configpackage can be published to npm for use in other projects.NOTE: This is 1 of 3 PR which should be merged together. It should be reviewed 2nd after #231 and merged 2nd after #233. Never mind the failing checks: it's due to actual fixes done in a dedicated PR.