Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(setting): implement basic local storage data exporter/importer #204

Merged
merged 2 commits into from
May 22, 2024

Conversation

ygrishajev
Copy link
Contributor

refs #56

@ygrishajev ygrishajev requested review from Redm4x and baktun14 May 17, 2024 16:10
@Redm4x
Copy link
Contributor

Redm4x commented May 21, 2024

Importing data will overwrite any existing data of the same key right? In my implementation of the Import from Cloudmos feature I ended up only importing new keys and merging existing wallets for certs. In this case users will most likely only import data if they have no current data (ex: got wiped), but I'm wondering if we should put a warning that existing data may be overwritten. Wdyt?

@ygrishajev
Copy link
Contributor Author

That was my concern as well. I'm not sure we need to try guessing what user wants. Having a warning is ideal imo too

@ygrishajev ygrishajev force-pushed the feature/data-manager branch from d9d1cfe to b4c7666 Compare May 22, 2024 10:54
@ygrishajev
Copy link
Contributor Author

@Redm4x @baktun14 to address what we discussed with @Redm4x above added a confirmation popup on data import attempt.
Also added a handy popup context/hook with promised based confirm method. This can be extended to other methods too. This approach reduces boilerplate code/duplication quite a bit.

@ygrishajev ygrishajev merged commit bf7445f into main May 22, 2024
6 checks passed
@ygrishajev ygrishajev deleted the feature/data-manager branch May 22, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants