Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy-web): add localstorage export page #195

Merged
merged 2 commits into from
May 15, 2024

Conversation

Redm4x
Copy link
Contributor

@Redm4x Redm4x commented May 14, 2024

Automatic localstorage migration from Cloudmos to Console

Added a page under /standalone/localstorage-export that will be used to automatically import the localstorage data from Cloudmos into Console. The page will be opened on Console in an iframe and the data will be transferred using the window.postMessage method.

Matching PR for Console side: #196

The exported data include:

  • Settings
  • Certificates
  • Deployment Names & SDLs
  • Provider Favorites

Security Concerns ⚠️

The exported data contains sensitive information so we must make sure it is handled securely.
To make sure the data does not end up on the wrong domain we pass the targetOrigin property to postMessage. The browser will make sure the message is only dispatched if the parent window has the correct origin https://console.akash.network.

postMessage documentation

Once the majority of users have migrated to Console, we could remove this page to mitigate any future security risk. We could also change it be opened as a popup instead and require user approval before sending the data.

@Redm4x Redm4x requested a review from baktun14 May 14, 2024 20:12
@Redm4x Redm4x marked this pull request as ready for review May 14, 2024 20:29
@Redm4x Redm4x merged commit e42709c into features/temp-cloudmos-maintain May 15, 2024
1 check passed
@Redm4x Redm4x deleted the features/add-console-export branch May 15, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants