Skip to content

Commit

Permalink
style(dx): fix type issues
Browse files Browse the repository at this point in the history
closes #223
  • Loading branch information
ygrishajev committed Jun 4, 2024
1 parent 8957b37 commit 9c46f70
Show file tree
Hide file tree
Showing 12 changed files with 103 additions and 29 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/validate-n-build-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ jobs:

- name: Install dependencies
if: steps.filter.outputs.api == 'true'
run: npm ci --workspace=apps/api
run: npm ci

- name: Run static code analysis
if: steps.filter.outputs.api == 'true'
run: npm run lint --workspace=apps/api
run: npm run lint:api

- name: Run unit tests
if: steps.filter.outputs.api == 'true'
Expand Down
4 changes: 3 additions & 1 deletion apps/deploy-web/src/chains/akash-sandbox.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { AssetList } from "@chain-registry/types";

import { akash, akashAssetList } from "./akash";

export const akashSandbox = {
Expand All @@ -12,4 +14,4 @@ export const akashSandbox = {
}
};

export const akashSandboxAssetList = { ...akashAssetList, chain_name: "akash-sandbox", assets: [...akashAssetList.assets] };
export const akashSandboxAssetList: AssetList = { ...akashAssetList, chain_name: "akash-sandbox", assets: [...akashAssetList.assets] };
4 changes: 3 additions & 1 deletion apps/deploy-web/src/chains/akash-testnet.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { AssetList } from "@chain-registry/types";

import { akash, akashAssetList } from "./akash";

export const akashTestnet = {
Expand All @@ -12,4 +14,4 @@ export const akashTestnet = {
}
};

export const akashTestnetAssetList = { ...akashAssetList, chain_name: "akash-testnet", assets: [...akashAssetList.assets] };
export const akashTestnetAssetList: AssetList = { ...akashAssetList, chain_name: "akash-testnet", assets: [...akashAssetList.assets] };
2 changes: 1 addition & 1 deletion apps/deploy-web/src/components/table/data-table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export function DataTable<TData, TValue>({

return (
<div className="space-y-4">
<DataTableToolbar table={table} hasStatusFilter={hasStatusFilter} />
<DataTableToolbar table={table} />
<div className="rounded-md border">
<Table>
<TableHeader>
Expand Down
1 change: 0 additions & 1 deletion apps/deploy-web/src/components/ui/form.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ type FormItemContextValue = {
const FormItemContext = React.createContext<FormItemContextValue>({} as FormItemContextValue);

const FormItem = React.forwardRef<HTMLDivElement, React.HTMLAttributes<HTMLDivElement>>(({ className, ...props }, ref) => {
// @ts-expect-error till types are outdated
const id = React.useId();

return (
Expand Down
4 changes: 0 additions & 4 deletions apps/deploy-web/src/components/ui/input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ export interface FormInputProps extends React.InputHTMLAttributes<HTMLInputEleme
const FormInput = React.forwardRef<HTMLInputElement, FormInputProps>(({ className, type, label, description, ...props }, ref) => {
return (
<FormItem>
{/** TODO */}
<Label>{label}</Label>
{/* <FormControl> */}
<input
type={type}
className={cn(
Expand All @@ -43,7 +41,6 @@ const FormInput = React.forwardRef<HTMLInputElement, FormInputProps>(({ classNam
ref={ref}
{...props}
/>
{/* </FormControl> */}
{description && <FormDescription>{description}</FormDescription>}
</FormItem>
);
Expand All @@ -62,7 +59,6 @@ export interface InputWithIconProps extends React.InputHTMLAttributes<HTMLInputE

const InputWithIcon = React.forwardRef<HTMLInputElement, InputWithIconProps>(
({ className, inputClassName, type, label, startIcon, endIcon, error, ...props }, ref) => {
// @ts-expect-error till types are outdated
const id = React.useId();

return (
Expand Down
12 changes: 12 additions & 0 deletions apps/indexer/src/indexers/messageAddressesIndexer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,4 +156,16 @@ export class MessageAddressesIndexer extends Indexer {

return { multisigThreshold, addresses };
}

initCache(): Promise<void> {
return Promise.resolve(undefined);
}

seed(): Promise<void> {
return Promise.resolve(undefined);
}

afterEveryBlock(): Promise<void> {
return Promise.resolve(undefined);
}
}
12 changes: 12 additions & 0 deletions apps/indexer/src/indexers/validatorIndexer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,4 +156,16 @@ export class ValidatorIndexer extends Indexer {

await validator.save({ transaction: dbTransaction });
}

initCache(): Promise<void> {
return Promise.resolve(undefined);
}

afterEveryTransaction(): Promise<void> {
return Promise.resolve(undefined);
}

afterEveryBlock(): Promise<void> {
return Promise.resolve(undefined);
}
}
3 changes: 3 additions & 0 deletions apps/stats-web/next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ const nextConfig = {
output: "standalone",
publicRuntimeConfig: {
version
},
eslint: {
ignoreDuringBuilds: true,
}
};

Expand Down
2 changes: 1 addition & 1 deletion apps/stats-web/src/app/addresses/[address]/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export default async function AddressDetailPage({ params: { address }, searchPar
<AssetList addressDetail={addressDetail} />
</div>
<div className="col-span-1 md:col-span-3">
<AssetAllocation address={address} addressDetail={addressDetail} />
<AssetAllocation addressDetail={addressDetail} />
</div>
</div>
</div>
Expand Down
Loading

0 comments on commit 9c46f70

Please sign in to comment.