Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] OpenMP support for compiled trees #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mwojcikowski
Copy link
Collaborator

@mwojcikowski mwojcikowski commented Nov 14, 2016

What's new:

  • new argument was introduced n_jobs for better performance model.predict(X, n_jobs=32)
  • n_jobs has similar behavior to joblib, i.e. n_jobs=-1 takes all CPUs, n_jobs=-2 leaves one core idle, etc.
  • the code is parallelized at samples level, which allows for good scaling, although theoretically you can't do n_jobs > n_samples
  • tree-level parallelizm is implemented for smaller sample sizes (< 2 * n_jobs)

Supported platforms:

  • Windows
  • Mac (GCC supports OpenMP, Xcode clang does not)
  • Linux

@mwojcikowski mwojcikowski changed the title [WIP] OpenMP [WIP] OpenMP support for compiled trees Nov 16, 2016
@mwojcikowski mwojcikowski force-pushed the openmp branch 3 times, most recently from 50afd45 to 0781bd8 Compare November 17, 2016 09:59
@codecov-io
Copy link

codecov-io commented Nov 18, 2016

Codecov Report

Merging #26 into master will decrease coverage by 6.22%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   98.37%   92.15%   -6.23%     
==========================================
  Files           4        4              
  Lines         308      344      +36     
==========================================
+ Hits          303      317      +14     
- Misses          5       27      +22
Impacted Files Coverage Δ
compiledtrees/compiled.py 92.3% <71.42%> (-4.96%) ⬇️
compiledtrees/code_gen.py 83.92% <83.33%> (-15.13%) ⬇️
compiledtrees/tests/test_compiled.py 98.02% <96.55%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b978cf2...8fc78f2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants