Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly file limit error #24

Closed

Conversation

ollieglass
Copy link
Contributor

As suggested here #22

@coveralls
Copy link

coveralls commented Nov 9, 2016

Coverage Status

Coverage decreased (-1.7%) to 97.49% when pulling aaad1ef on ollieglass:friendly_file_limit_error into 36f909d on ajtulloch:master.

@mwojcikowski
Copy link
Collaborator

I don't like the use of bit.ly, It would be much useful if we had an information about this in the README.

I've got an idea, that we could predict obvious failures, i.e. when the limit is below the predicted usage, issue a warning message and/or try to increase the limit within the script via resource module.

@mwojcikowski
Copy link
Collaborator

Plus, such error can come up on every NamedTemporaryFile not only in one place. I'm against wrapping all of them up in try: except. The best solution would be, in my mind, simple check for the resource limit and issue a warning that things will break.

I don't agree that these errors are dubious in any way for Linux/Mac.

@ollieglass ollieglass closed this Mar 22, 2022
@ollieglass ollieglass deleted the friendly_file_limit_error branch March 22, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants