Use crowdsourced title even if formatter is disabled

- If the auto-formatter is disabled in the options and a custom title for a video is only changing capitalisation, the addon would previously show the original title instead.
ajayyy · May 16, 2024 · 4d5b657 · 4d5b657
1 parent bd4c8ec
commit 4d5b657
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/titles/titleRenderer.ts b/src/titles/titleRenderer.ts
@@ -71,11 +71,7 @@ export async function replaceTitle(element: HTMLElement, videoID: VideoID, showC
 
         const title = titleData?.title;
         const originalTitle = originalTitleElement?.textContent?.trim?.() ?? "";
-        if (title && await shouldUseCrowdsourcedTitles(videoID)
-                // If there are just formatting changes, and the user doesn't want those, don't replace
-                && (await getTitleFormatting(videoID) !== TitleFormatting.Disable || originalTitle.toLowerCase() !== title.toLowerCase())
-                && (await getTitleFormatting(videoID) !== TitleFormatting.Disable 
-                    || await shouldCleanEmojis(videoID) || cleanEmojis(originalTitle.toLowerCase()) !== cleanEmojis(title.toLowerCase()))) {
+        if (title && await shouldUseCrowdsourcedTitles(videoID)) {
             const formattedTitle = await formatTitle(title, true, videoID);
             if (!await isOnCorrectVideo(element, brandingLocation, videoID)) return false;
 

diff --git a/src/videoBranding/videoBranding.ts b/src/videoBranding/videoBranding.ts
@@ -290,8 +290,7 @@ export async function handleShowOriginalButton(element: HTMLElement, videoID: Vi
     if (result || (await Promise.all(promises)).some((r) => r)) {
         const title = await getVideoTitleIncludingUnsubmitted(videoID, brandingLocation);
         const originalTitle = getOriginalTitleElement(element, brandingLocation)?.textContent;
-        const customTitle = title && !title.original 
-            && (!originalTitle || (cleanResultingTitle(cleanEmojis(title.title))).toLowerCase() !== (cleanResultingTitle(cleanEmojis(originalTitle))).toLowerCase())
+        const customTitle = title && !title.original
             && await shouldUseCrowdsourcedTitles(videoID);
 
         if (!customTitle && !Config.config!.showIconForFormattedTitles && !await promises[1]) {