Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ… feat: 🎸 Interactive Map component #251

Conversation

yashksaini-coder
Copy link

βœ… Closes: #238

This pull request includes updates to dependencies, the addition of a new interactive map feature, and improvements to the codebase for better maintainability. The most important changes are outlined below:

Dependency Updates:

  • Updated react and react-dom to version 18.3.1 in package.json.
  • Added @react-google-maps/api and react-leaflet to package.json dependencies. [1] [2]

New Feature:

  • Introduced an InteractiveMap component in src/components/ui/InteractiveMap.tsx that integrates Google Maps API to display an interactive map with markers for various locations in Uttarakhand.
  • Integrated the InteractiveMap component into the Explore page in src/app/explore/page.tsx. [1] [2]

Codebase Improvements:

  • Removed the non-null assertion from the DATABASE_URL environment variable in src/lib/drizzle.ts for better error handling.

uttarakhand-238.webm

@ajaynegi45 can you review this PR, and assign it to me with proper labels

Copy link

vercel bot commented Nov 3, 2024

@yashksaini-coder is attempting to deploy a commit to the ajaynegi45's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰ Thank you @yashksaini-coder for your contribution! Your pull request has been submitted successfully, and a maintainer will review it soon. We’re excited to have you on board! For updates and community support, join our Discord and be part of the conversation. Remember to star the repo 🌟 to help us grow, and follow @ajaynegi45 to stay in the loop and increase the visibility of your contributions!

Copy link
Owner

@ajaynegi45 ajaynegi45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yashksaini-coder,

Thank you for your prompt work on this issue. I appreciate your dedication to the project.

I have reviewed your work, and I need some changes.

  • Not meet the issue requirements.
  • Also resolve conflicts.

Once again, thank you for your contribution! ❀️

@ajaynegi45 ajaynegi45 closed this Nov 12, 2024
@yashksaini-coder yashksaini-coder deleted the yashksaini-coder/issue238 branch November 12, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Interactive Map for Cultural Hotspots
2 participants