Better separate type declarations #5695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
# Conflicts: # ace-internal.d.ts # ace.d.ts # src/autocomplete.js # tool/ace_declaration_generator.js # tsconfig.json # types/ace-ext.d.ts # types/ace-lib.d.ts # types/ace-modules.d.ts
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
# Conflicts: # src/edit_session.js # types/ace-modules.d.ts
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
mkslanc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This update builds on the work from #5427 to refine the TypeScript declaration generation, now producing separate, module-specific declaration files.
Benefits:
Result:
These changes yield a cleaner, more maintainable public API surface.
Before:
After:
Discussion Point: Allowing Index Signatures for Classes
We could consider adding an index signature to the class to allow dynamic properties. This can be helpful when properties are not known at compile time but need to be added later.
While this provides flexibility, it comes at the cost of reduced type safety, as any property can be added without restrictions.
Still could be a good tradeoff for situations like #5696 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references: