Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small tweaks LineWidget type #5683

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

akoreman
Copy link
Contributor

Issue #, if available: NA

Description of changes: In #5673, we recently exposed LineWidget interface, this makes some small tweaks to it by making hidden, editor and session optional bringing the external type definition a bit closer to the internal type.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (442680c) to head (da3496e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5683   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files         598      598           
  Lines       43683    43683           
  Branches     7204     7204           
=======================================
  Hits        38012    38012           
  Misses       5671     5671           
Flag Coverage Δ
unittests 87.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@akoreman akoreman merged commit b3625f3 into ajaxorg:master Nov 21, 2024
4 checks passed
@akoreman akoreman deleted the linewidget_type_fix branch November 21, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants