feat: Multiline Search Support: line breaks `\n` #5675

sekedus · 2024-11-15T12:34:45Z

Issue #2869

Description of changes:

highlight line break \n
search line break \n
replace line break \n
replace {search} value with \n or \t
ㅤ

Benefit

Users can now perform search/replace line breaks (\n) with regex.
ㅤ

Test

Open: https://sekedus.github.io/ace/kitchen-sink.html
Settings: Document: JavaScript
Set value:

/**
 * 
 * @param {string[]} items
 * @param nada
 */
function foo(items, nada) {
    for (var i=0; i<items.length; i++) {
        alert(items[i] + "juhu\n");
    }	/* Real Tab */




}


// test search/replace line break with regexp

Open search box
- Fill in search field with \n or \n+ or \n\s+ or \)\s\{\n\s+
- Enable RegExp mode
Example:
- Replace two or more line breaks with one line break:
  - \n{2} with \n
  - \n+ with \n
- Remove line breaks, replace \n with {empty}
- Replace {any_string} with \n or\t
  ㅤ

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

No backwards incompatible changes were made to Ace's public interface which is defined through the main typings file (ace.d.ts) and its references:

* highlight line break * search line break * replace line break

Replace `.ace_search_form input` value with `\n` and `\t` using regex.

whazor · 2024-11-18T09:41:34Z

Does this also resolve #5674?

sekedus · 2024-11-18T10:39:31Z

Does this also resolve #5674?

ㅤ
Yes.

src/search.js

- Auto updates "updateCounter" and "ace_nomatch" in the search box when "onDocumentChange" - If regex mode is enabled, fill the "searchInput" field with "escapeRegExp"

src/search_highlight.js

src/ext/searchbox.js

nlujjawal · 2024-11-20T15:49:10Z

src/search.js

+            for (var matches, i = 0; i < lines.length; i++) {
+                if (this.$isMultilineSearch(options)) {
+                    matches = this.$multiLineForward(session, re, i, lines.length);
+                    ranges.push(new Range(matches.startRow, matches.startCol, matches.endRow, matches.endCol));


+1 as the previous case

nlujjawal · 2024-11-20T15:57:46Z

src/search.js

@@ -166,11 +240,15 @@ class Search {
        if (!re)
            return;

+        if (this.$isMultilineSearch(options))


these are used at 2 places should we create another method as this looks like the reusable code.

src/search.js

nlujjawal · 2024-11-21T07:48:46Z

src/search.js

-                    var column = matches[i - 1];
-                    var length = matches[i];
-                    if (callback(row, column, row, column + length))
+                if (multiline) {


should we reset regex lastIndex above this line just to reset it?
re.lastIndex = 0;

Yes, see: https://stackoverflow.com/a/4724920

Sorry, I wasn’t focused earlier.

No need, because it’s already set in multiLineBackwardMatch.

src/search.js

nlujjawal · 2024-11-21T15:15:03Z

Hey @sekedus
Do you have time for writing test cases for the changes as well?

sekedus · 2024-11-22T23:54:12Z

Hey @sekedus Do you have time for writing test cases for the changes as well?

Done.

https://sekedus.github.io/ace/src/test/tests.html?ace/search_test

codecov · 2024-11-26T10:08:38Z

Codecov Report

Attention: Patch coverage is 76.26459% with 61 lines in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (6dfb903) to head (b9ca369).
Report is 16 commits behind head on master.

Files with missing lines	Patch %	Lines
src/search.js	68.90%	51 Missing ⚠️
src/search_highlight.js	56.52%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5675      +/-   ##
==========================================
- Coverage   87.01%   86.95%   -0.07%     
==========================================
  Files         598      598              
  Lines       43680    43801     +121     
  Branches     7204     7208       +4     
==========================================
+ Hits        38009    38085      +76     
- Misses       5671     5716      +45

Flag	Coverage Δ
unittests	`86.95% <76.26%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nlujjawal · 2024-11-26T13:54:16Z

@sekedus some test case requirement is failing will you be able to resolve this?

sekedus · 2024-11-27T12:50:56Z

@sekedus some test case requirement is failing will you be able to resolve this?

Sorry, I don't know where the error is and how to resolve it.

Any suggestions?

nightwing · 2024-11-28T11:39:45Z

src/editor.js

+
+        // Updates "updateCounter" and "ace_nomatch" in the search box
+        if (this.searchBox && this.searchBox.active === true)
+            this.searchBox.find(false, false, true);


Could you please move this to an input event handler in searchbox, something like editor.on('input', this.$onEditorInput) and remove the listener when deactivating. onDocumentChange can be called multiple times during one edit, and input event debounces that with a timeout.
Also in one of tests add a scenario of changing editor value, e.g.

editor.insert("searchedText") setTimeout(function() { // verify that search counter have been updated }, 50)

to prevent coverlay complaining about untested lines

nlujjawal · 2024-11-28T13:26:34Z

@sekedus The failure of checks is due to some lines of code not having test cases.
You can view in this link about those lines https://github.com/ajaxorg/ace/pull/5675/checks?check_run_id=33534340733.

sekedus added 2 commits November 15, 2024 19:16

add: search/replace line break

ad7e035

* highlight line break * search line break * replace line break

search multiline match \n+

2c5dbeb

sekedus mentioned this pull request Nov 15, 2024

Search/replace for line break #5027

Closed

sekedus marked this pull request as draft November 15, 2024 22:58

sekedus marked this pull request as ready for review November 16, 2024 01:53

sekedus marked this pull request as draft November 16, 2024 13:29

sekedus force-pushed the master branch from 02bc602 to cdf2fdb Compare November 17, 2024 05:38

fix: replace with \n and \t

cdf2fdb

Replace `.ace_search_form input` value with `\n` and `\t` using regex.

sekedus marked this pull request as ready for review November 17, 2024 12:53

sekedus mentioned this pull request Nov 18, 2024

[FEATURE REQUEST] Process regex escapes as on PC Acode-Foundation/Acode#280

Open

sekedus marked this pull request as draft November 18, 2024 11:47

InspiredGuy requested a review from nightwing November 18, 2024 12:37

nlujjawal reviewed Nov 18, 2024

View reviewed changes

src/search.js Show resolved Hide resolved

searchBox: auto update & escape regex

f60060d

- Auto updates "updateCounter" and "ace_nomatch" in the search box when "onDocumentChange" - If regex mode is enabled, fill the "searchInput" field with "escapeRegExp"

sekedus marked this pull request as ready for review November 18, 2024 22:20

nlujjawal reviewed Nov 21, 2024

View reviewed changes

src/search.js Outdated Show resolved Hide resolved

src/search.js Show resolved Hide resolved

sekedus force-pushed the master branch from fe20196 to c45522a Compare November 21, 2024 14:15

nlujjawal approved these changes Nov 21, 2024

View reviewed changes

nlujjawal mentioned this pull request Nov 21, 2024

WIP: Ported Cloud9 Find Replace Plugin to Ace Editor with Enhancements #5502

Draft

sekedus force-pushed the master branch from c45522a to d530af2 Compare November 21, 2024 22:31

fix and add comments

d530af2

sekedus force-pushed the master branch from 861e5d8 to 318dd9a Compare November 22, 2024 02:10

fix: search box updateCounter

318dd9a

sekedus force-pushed the master branch 2 times, most recently from 3a15da5 to cfb17ca Compare November 24, 2024 06:03

sekedus added 2 commits November 24, 2024 14:03

fix and add test

cfb17ca

fix build

45851b9

nightwing approved these changes Nov 28, 2024

View reviewed changes

sekedus force-pushed the master branch 3 times, most recently from 56f0455 to 23b06f9 Compare December 2, 2024 12:08

akoreman changed the title ~~Multiline Search Support: line breaks \n~~ feat: Multiline Search Support: line breaks \n Dec 3, 2024

sekedus force-pushed the master branch from 23b06f9 to e87351f Compare December 3, 2024 22:25

fix: codecov missing coverage

b9ca369

sekedus force-pushed the master branch from e87351f to b9ca369 Compare December 4, 2024 07:35

nlujjawal self-requested a review December 5, 2024 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Multiline Search Support: line breaks `\n` #5675

feat: Multiline Search Support: line breaks `\n` #5675

sekedus commented Nov 15, 2024 •

edited

Loading

whazor commented Nov 18, 2024

sekedus commented Nov 18, 2024 •

edited

Loading

nlujjawal Nov 20, 2024

sekedus Nov 21, 2024

nlujjawal Nov 20, 2024

sekedus Nov 21, 2024

nlujjawal Nov 21, 2024

sekedus Nov 21, 2024

sekedus Nov 21, 2024

nlujjawal commented Nov 21, 2024

sekedus commented Nov 22, 2024 •

edited

Loading

codecov bot commented Nov 26, 2024 •

edited

Loading

nlujjawal commented Nov 26, 2024

sekedus commented Nov 27, 2024

nightwing Nov 28, 2024

nlujjawal commented Nov 28, 2024

feat: Multiline Search Support: line breaks \n #5675

Are you sure you want to change the base?

feat: Multiline Search Support: line breaks \n #5675

Conversation

sekedus commented Nov 15, 2024 • edited Loading

Benefit

Test

whazor commented Nov 18, 2024

sekedus commented Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nlujjawal commented Nov 21, 2024

sekedus commented Nov 22, 2024 • edited Loading

codecov bot commented Nov 26, 2024 • edited Loading

Codecov Report

nlujjawal commented Nov 26, 2024

sekedus commented Nov 27, 2024

Choose a reason for hiding this comment

nlujjawal commented Nov 28, 2024

feat: Multiline Search Support: line breaks `\n` #5675

feat: Multiline Search Support: line breaks `\n` #5675

sekedus commented Nov 15, 2024 •

edited

Loading

sekedus commented Nov 18, 2024 •

edited

Loading

sekedus commented Nov 22, 2024 •

edited

Loading

codecov bot commented Nov 26, 2024 •

edited

Loading