Merge pull request #5366 from akoreman/doc_tooltip_fix

Fixes bug where the completion doc tooltip would not be filtered properly because it would get the data from the popup before it was updated.

src/autocomplete.js

@@ -464,7 +464,7 @@ class Autocomplete {
 
     updateDocTooltip() {
         var popup = this.popup;
-        var all = popup.data;
+        var all = this.completions.filtered;
         var selected = all && (all[popup.getHoveredRow()] || all[popup.getRow()]);
         var doc = null;
         if (!selected || !this.editor || !this.popup.isOpen)

src/autocomplete_test.js

@@ -297,6 +297,60 @@ module.exports = {
             }, 10);
         }
     },
+    "test: completers tooltip filtering": function (done) {
+        var editor = initEditor("");
+        var firstDoc = "First tooltip";
+        var secondDoc = "Second tooltip";
+        editor.completers = [
+            {
+                getCompletions: function (editor, session, pos, prefix, callback) {
+                    var completions = [
+                        {
+                            caption: "case",
+                            value: "case"
+                        }, {
+                            caption: "catch",
+                            value: "catch"
+                        }
+                    ];
+                    callback(null, completions);
+                },
+                getDocTooltip: function (item) {
+                    if (item.value === 'case') {
+                        item.docHTML = firstDoc;
+                    } 
+                    if (item.value === 'catch') {
+                        item.docHTML = secondDoc;
+                    }
+                }
+            }
+        ];
+
+        sendKey("ca");
+        var popup = editor.completer.popup;
+
+        check(function() {
+            assert.equal(popup.data.length, 2);
+            assert.equal(popup.container.lastChild.innerHTML, firstDoc);
+
+            sendKey("t");
+
+            check(function() {
+                assert.equal(popup.data.length, 1);
+                assert.equal(popup.container.lastChild.innerHTML, secondDoc);
+
+                editor.destroy();
+                editor.container.remove();
+                done();
+            });
+        });
+
+        function check(callback) {
+            setTimeout(function wait() {
+                callback();
+            }, 10);
+        }
+    },
     "test: slow and fast completers": function(done) {
         var syncCompleter={
             getCompletions: function(editor, session, pos, prefix, callback) {