Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose writing problem files to file #51

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

sstroemer
Copy link
Member

This is basically just a small wrapper around JuMP.write_to_file and fixes #50.


Auto Summary:
This pull request includes several changes to the IESopt project, focusing on adding new functionality for writing models to files, updates the test Manifest, and implements related tests. The most important changes are summarized below:

New Functionality:

  • Added a new write_to_file function in src/IESopt.jl to write IESopt models to files with specified filenames and formats. This includes handling automatic format detection based on file extensions and additional keyword arguments.

Was in use previously anyways (currently commented out) to hash input files. Now "only" used in tests (could be added there), but expected to be a dependency anyways.
…ign with other test sets that might construct model files
…after writing them to common problem files
@sstroemer sstroemer requested a review from daschw January 9, 2025 00:44
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.57%. Comparing base (91d38b2) to head (5906e8c).
Report is 8 commits behind head on main.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   49.31%   49.57%   +0.25%     
==========================================
  Files         109      109              
  Lines        4281     4303      +22     
==========================================
+ Hits         2111     2133      +22     
  Misses       2170     2170              
Files with missing lines Coverage Δ
src/IESopt.jl 59.31% <100.00%> (+2.98%) ⬆️

@sstroemer
Copy link
Member Author

After this is merged and a new release is triggered, we can get this Python wrapper PR merged.

Copy link
Collaborator

@daschw daschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sstroemer sstroemer merged commit 90235d4 into ait-energy:main Jan 10, 2025
6 checks passed
@sstroemer sstroemer deleted the feature-write-to-file branch January 10, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "write_X" functionality
3 participants