-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose writing problem files to file #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was in use previously anyways (currently commented out) to hash input files. Now "only" used in tests (could be added there), but expected to be a dependency anyways.
…ign with other test sets that might construct model files
…after writing them to common problem files
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 49.31% 49.57% +0.25%
==========================================
Files 109 109
Lines 4281 4303 +22
==========================================
+ Hits 2111 2133 +22
Misses 2170 2170
|
After this is merged and a new release is triggered, we can get this Python wrapper PR merged. |
daschw
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically just a small wrapper around
JuMP.write_to_file
and fixes #50.Auto Summary:
This pull request includes several changes to the
IESopt
project, focusing on adding new functionality for writing models to files, updates the test Manifest, and implements related tests. The most important changes are summarized below:New Functionality:
write_to_file
function insrc/IESopt.jl
to writeIESopt
models to files with specified filenames and formats. This includes handling automatic format detection based on file extensions and additional keyword arguments.