Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with captn #44

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Integrate with captn #44

merged 3 commits into from
Jul 10, 2024

Conversation

rjambrecic
Copy link
Collaborator

@rjambrecic rjambrecic commented Jul 10, 2024 •
edited
Loading

Description

  1. Default parameters set in endpoints (because FastAgency issues)
  2. /login/callback endpoint updated to redirect to Captn

Type of change

Please delete options that are not relevant.

  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@rjambrecic rjambrecic requested a review from kumaranvpl July 10, 2024 08:12
@kumaranvpl kumaranvpl added this pull request to the merge queue Jul 10, 2024
Merged via the queue into dev with commit b942d22 Jul 10, 2024
17 checks passed
@kumaranvpl kumaranvpl deleted the integrate-with-captn branch July 10, 2024 08:29
@rjambrecic rjambrecic linked an issue Jul 11, 2024 that may be closed by this pull request
Build and test google sheets API #37
Closed
@rjambrecic rjambrecic mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaranvpl kumaranvpl kumaranvpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build and test google sheets API
2 participants
@rjambrecic @kumaranvpl