Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #30, #31 #32

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Dev #30, #31 #32

merged 2 commits into from
Jun 28, 2024

Conversation

kumaranvpl
Copy link
Collaborator

Description

Merge PRs #30, #31

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

rjambrecic and others added 2 commits June 27, 2024 04:33
@rjambrecic
Implement endpoints for creating and updating sheet (#30)
f3d8368 
* wip

* Refactoring

* Fix tests

* Refactoring

* Add tests for create-sheet endpoint

* Initial update-sheet implementation

* Asyncify part of update-sheet endpoint

* wip

* Update tests

* Refactoring wip

* Refactoring

* Implement get-all-sheet-titles endpoint

* Update tests
@kumaranvpl
Always restart docker (#31)
1a37abf
@kumaranvpl kumaranvpl requested a review from rjambrecic June 28, 2024 09:50
@rjambrecic rjambrecic added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 55789ac Jun 28, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjambrecic rjambrecic rjambrecic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaranvpl @rjambrecic