Skip to content

Commit

Permalink
Updated ad copy structure
Browse files Browse the repository at this point in the history
  • Loading branch information
rjambrecic committed Sep 11, 2024
1 parent 07272ff commit 5a4acce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion google_sheets/data_processing/processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,12 @@ def process_data_f(
].str.upper()
template_df["Language Code"] = template_df["Language Code"].str.upper()
new_campaign_df["Language Code"] = new_campaign_df["Language Code"].str.upper()
on = ["Language Code", "Match Type"] if target_resource == "ad" else "Language Code"
template_df = pd.merge(
merged_campaigns_ad_groups_df,
template_df,
how="inner",
on="Language Code",
on=on,
)

_validate_language_codes(
Expand Down
2 changes: 2 additions & 0 deletions tests/app/test_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@ async def test_process_data_ads(self) -> None:
"Description Line 2",
"Path 1",
"Path 2",
"Match Type",
],
[
"EN",
Expand All @@ -526,6 +527,7 @@ async def test_process_data_ads(self) -> None:
"Description Line 2",
"Path 1",
"Path 2",
"Exact",
],
]
)
Expand Down

0 comments on commit 5a4acce

Please sign in to comment.