Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(beacon-ui): make qrcode work with rollup/vite #345

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

souljorje
Copy link
Contributor

TL;DR: if you don't plan to use namespaced imports from CJS don't use import * otherwise rollups' output.interop breaks usage of default exported function.

related:
#170
rollup/rollup#1267
kazuhikoarase/qrcode-generator#62

@souljorje souljorje changed the title fix(ui): make qrcode work with rollup/vite fix(beacon-ui): make qrcode work with rollup/vite May 12, 2022
@souljorje souljorje marked this pull request as draft May 12, 2022 17:13
@souljorje souljorje marked this pull request as ready for review May 12, 2022 17:31
@itsnamangoyal
Copy link

We are also using vite for framework and production app is missing qrcode.

@itsnamangoyal
Copy link

@AndreasGassmann Can you look into this one with a higher priority 😅? thank you

@souljorje
Copy link
Contributor Author

@itsnamangoyal here's a workaround #170 (comment)

@AndreasGassmann
Copy link
Member

Hi, sorry for getting back to you so late.

Thanks for creating this PR. Historically, we had a lot of issues with different build environments, primarily because of the QR dependency and libsodium. It usually works with Angular / Webpack (which we use most), but it frequently had issues with other systems.

Before I merge this, I would like to make sure that this doesn't introduce a regression for other frameworks such as Angular. Once I can confirm that it also works there, I will merge it.

@PureSpider
Copy link

@AndreasGassmann any news on this?

@AndreasGassmann AndreasGassmann changed the base branch from master to fix/qr-build-issues September 22, 2022 11:59
@AndreasGassmann
Copy link
Member

Hi. Sorry for the delay (again).

We have finally replaced libsodium in 3.2.0, now I'd like to tackle this. I will merge it into a branch so I can release a beta version from our CI.

@AndreasGassmann AndreasGassmann merged commit b9aea90 into airgap-it:fix/qr-build-issues Sep 22, 2022
@RichAyotte
Copy link
Contributor

RichAyotte commented Jan 29, 2023

@AndreasGassmann I noticed https://github.com/airgap-it/beacon-sdk/tree/fix/qr-build-issues hasn't been merged yet. Is anything more needed for this?

edit:
pr: #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants