-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(beacon-ui): make qrcode work with rollup/vite #345
fix(beacon-ui): make qrcode work with rollup/vite #345
Conversation
We are also using vite for framework and production app is missing qrcode. |
@AndreasGassmann Can you look into this one with a higher priority 😅? thank you |
@itsnamangoyal here's a workaround #170 (comment) |
Hi, sorry for getting back to you so late. Thanks for creating this PR. Historically, we had a lot of issues with different build environments, primarily because of the QR dependency and libsodium. It usually works with Angular / Webpack (which we use most), but it frequently had issues with other systems. Before I merge this, I would like to make sure that this doesn't introduce a regression for other frameworks such as Angular. Once I can confirm that it also works there, I will merge it. |
@AndreasGassmann any news on this? |
Hi. Sorry for the delay (again). We have finally replaced |
@AndreasGassmann I noticed https://github.com/airgap-it/beacon-sdk/tree/fix/qr-build-issues hasn't been merged yet. Is anything more needed for this? edit: |
TL;DR: if you don't plan to use namespaced imports from CJS don't use
import *
otherwise rollups' output.interop breaks usage of default exported function.related:
#170
rollup/rollup#1267
kazuhikoarase/qrcode-generator#62