Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Railz: Migrate to manifest-only format #47244

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
22bbcc3
Source Railz: Migrate to manifest-only format
btkcodedev Oct 22, 2024
cf2bdb2
Source Railz: Migrate to manifest-only format
btkcodedev Oct 22, 2024
ea45a77
chore: auto-fix lint and format issues
octavia-squidington-iii Oct 22, 2024
5964e65
Merge branch 'master' into btkcodedev/railzMigrate
btkcodedev Dec 6, 2024
e262b57
Merge branch 'btkcodedev/railzMigrate' of https://github.com/airbyteh…
btkcodedev Dec 6, 2024
891d275
Merge branch 'master' into btkcodedev/railzMigrate
btkcodedev Jan 14, 2025
97c3e41
revert unit tests
btkcodedev Jan 16, 2025
ef2e6e2
Merge branch 'master' into btkcodedev/railzMigrate
btkcodedev Jan 16, 2025
42bf77c
update path
btkcodedev Jan 16, 2025
cc4654c
Merge branch 'btkcodedev/railzMigrate' of https://github.com/airbyteh…
btkcodedev Jan 16, 2025
c8fa45c
Merge branch 'master' into btkcodedev/railzMigrate
DanyloGL Jan 16, 2025
ca664d2
chore: auto-fix lint and format issues
octavia-squidington-iii Jan 16, 2025
a67b1c7
revert unit tests
btkcodedev Jan 16, 2025
df421bf
Merge branch 'btkcodedev/railzMigrate' of https://github.com/airbyteh…
btkcodedev Jan 16, 2025
e4ec63e
update declarative manifest version
btkcodedev Jan 16, 2025
6529448
update poetry locks
btkcodedev Jan 16, 2025
af058c7
remove unncessary tests
btkcodedev Jan 16, 2025
3c079e7
Merge branch 'master' into btkcodedev/railzMigrate
DanyloGL Jan 17, 2025
c0c62bd
revert tests
btkcodedev Jan 17, 2025
2db0c63
Merge branch 'btkcodedev/railzMigrate' of https://github.com/airbyteh…
btkcodedev Jan 17, 2025
37fe03b
fix pyproject.toml
btkcodedev Jan 17, 2025
475c5c8
Update pyproject
btkcodedev Jan 17, 2025
7fad7ef
add dev deps
btkcodedev Jan 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 27 additions & 53 deletions airbyte-integrations/connectors/source-railz/README.md
Original file line number Diff line number Diff line change
@@ -1,89 +1,63 @@
# Railz source connector

This directory contains the manifest-only connector for `source-railz`.
This _manifest-only_ connector is not a Python package on its own, as it runs inside of the base `source-declarative-manifest` image.

This is the repository for the Railz source connector, written in Python.
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.com/integrations/sources/railz).
For information about how to configure and use this connector within Airbyte, see [the connector's full documentation](https://docs.airbyte.com/integrations/sources/railz).

## Local development

### Prerequisites
* Python (~=3.9)
* Poetry (~=1.7) - installation instructions [here](https://python-poetry.org/docs/#installation)
We recommend using the Connector Builder to edit this connector.
Using either Airbyte Cloud or your local Airbyte OSS instance, navigate to the **Builder** tab and select **Import a YAML**.
Then select the connector's `manifest.yaml` file to load the connector into the Builder. You're now ready to make changes to the connector!

If you prefer to develop locally, you can follow the instructions below.

### Installing the connector
From this connector directory, run:
```bash
poetry install --with dev
```


### Create credentials
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.com/integrations/sources/railz)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_railz/spec.yaml` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `sample_files/sample_config.json` for a sample config file.


### Locally running the connector
```
poetry run source-railz spec
poetry run source-railz check --config secrets/config.json
poetry run source-railz discover --config secrets/config.json
poetry run source-railz read --config secrets/config.json --catalog sample_files/configured_catalog.json
```
### Building the docker image

### Running unit tests
To run unit tests locally, from the connector directory run:
```
poetry run pytest unit_tests
```
You can build any manifest-only connector with `airbyte-ci`:

### Building the docker image
1. Install [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md)
2. Run the following command to build the docker image:

```bash
airbyte-ci connectors --name=source-railz build
```

An image will be available on your host with the tag `airbyte/source-railz:dev`.

### Creating credentials

**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.com/integrations/sources/railz)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `spec` object in the connector's `manifest.yaml` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.

### Running as a docker container
Then run any of the connector commands as follows:
```

Then run any of the standard source connector commands:

```bash
docker run --rm airbyte/source-railz:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-railz:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-railz:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-railz:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```

### Running our CI test suite
You can run our full test suite locally using [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md):
```bash
airbyte-ci connectors --name=source-railz test
```
### Running the CI test suite

### Customizing acceptance Tests
Customize `acceptance-test-config.yml` file to configure acceptance tests. See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) for more information.
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
You can run our full test suite locally using [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md):

### Dependency Management
All of your dependencies should be managed via Poetry.
To add a new dependency, run:
```bash
poetry add <package-name>
airbyte-ci connectors --name=source-railz test
```

Please commit the changes to `pyproject.toml` and `poetry.lock` files.

## Publishing a new version of the connector
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
1. Make sure your changes are passing our test suite: `airbyte-ci connectors --name=source-railz test`
2. Bump the connector version (please follow [semantic versioning for connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors)):

If you want to contribute changes to `source-railz`, here's how you can do that:
1. Make your changes locally, or load the connector's manifest into Connector Builder and make changes there.
2. Make sure your changes are passing our test suite with `airbyte-ci connectors --name=source-railz test`
3. Bump the connector version (please follow [semantic versioning for connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors)):
- bump the `dockerImageTag` value in in `metadata.yaml`
- bump the `version` value in `pyproject.toml`
3. Make sure the `metadata.yaml` content is up to date.
4. Make sure the connector documentation and its changelog is up to date (`docs/integrations/sources/railz.md`).
5. Create a Pull Request: use [our PR naming conventions](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#pull-request-title-convention).
6. Pat yourself on the back for being an awesome contributor.
Expand Down
3 changes: 0 additions & 3 deletions airbyte-integrations/connectors/source-railz/__init__.py

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ test_strictness_level: "high"
acceptance_tests:
spec:
tests:
- spec_path: "source_railz/spec.yaml"
- spec_path: "manifest.yaml"
connection:
tests:
- config_path: "secrets/config.json"
Expand All @@ -23,7 +23,9 @@ acceptance_tests:
exact_order: no
empty_streams:
- name: "businesses"
bypass_reason: "Stream object fields like 'status' and 'updatedAt' can change pretty often"
bypass_reason:
"Stream object fields like 'status' and 'updatedAt' can change
pretty often"
incremental:
tests:
- config_path: "secrets/config.json"
Expand All @@ -32,6 +34,7 @@ acceptance_tests:
future_state_path: "integration_tests/abnormal_state.json"
full_refresh:
tests:
- config_path: "secrets/config.json"
# stream "accounting_transactions" too volatile
- config_path:
"secrets/config.json"
# stream "accounting_transactions" too volatile
configured_catalog_path: "integration_tests/configured_catalog_skip_accounting_transactions.json"
9 changes: 0 additions & 9 deletions airbyte-integrations/connectors/source-railz/main.py

This file was deleted.

Loading
Loading