✨Source Freshsales: Make Connector Compatible with Builder #38153
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
|
The filter streams are used as parent streams for other streams, I couldn't find a way to use those streams only internally and not expose them to the users while migrating this to the builder. If there's a way to specify that a stream needs to be used only internally but not exposed to the users, that could be great. This will be useful for streams that are to be used as parent streams for other streams but not as standalone streams. Maybe a checkbox to denote that the stream is internal only in the builder. |
| @@ -20,6 +20,13 @@ acceptance_tests: | |||
| - config_path: "secrets/config.json" | |||
| expect_records: | |||
| path: "integration_tests/expected_records.jsonl" | |||
| empty_streams: | |||
| - name: "sales_accounts_filter" | |||
There was a problem hiding this comment.
are the tests failing on master too?
There was a problem hiding this comment.
The master branch does not have these filter streams exposed to the user. The filter streams are used only internally in the manifest.
However when using the builder, if I want to use the filter streams as a parent stream for another stream, I need to expose the streams. So basically the user will be able to see 3 new streams. But we don't want the user to use these streams.
Having a checkbox such as use internally only in the builder would be a nice addition where the stream will not be exposed to the user, but we could still be able to use the stream as a parent stream for another stream.
Co-authored-by: Alexandre Girard <[email protected]>
What
Makes the connector compatible with the Builder UI
How
User Impact
Non impacting, done for maintainability
Can this PR be safely reverted and rolled back?