source-woocommerce: ensure inline schemas, updated cdk, poetry, generate builder manifest

airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/tests/test_core.py

@@ -717,7 +717,11 @@ def test_defined_cursors_exist_in_schema(self, discovered_catalog: Mapping[str,
         for stream_name, stream in discovered_catalog.items():
             if not stream.default_cursor_field:
                 continue
+
             schema = stream.json_schema
+            if not schema:
+                pytest.skip("Skipping `test_defined_cursors_exist_in_schema` because this connector doesn't have a JSON schema.")
+
             assert "properties" in schema, f"Top level item should have an 'object' type for {stream_name} stream schema"
             cursor_path = "/properties/".join(stream.default_cursor_field)
             cursor_field_location = dpath.util.search(schema["properties"], cursor_path)
@@ -752,6 +756,9 @@ def test_primary_keys_exist_in_schema(self, discovered_catalog: Mapping[str, Any
         for stream_name, stream in discovered_catalog.items():
             for pk in stream.source_defined_primary_key or []:
                 schema = stream.json_schema
+                if not schema:
+                    pytest.skip("Skipping `test_primary_keys_exist_in_schema` because this connector doesn't have a JSON schema.")
+
                 pk_path = "/properties/".join(pk)
                 pk_field_location = dpath.util.search(schema["properties"], pk_path)
                 assert pk_field_location, f"One of the PKs ({pk}) is not specified in discover schema for {stream_name} stream"

airbyte-integrations/connectors/source-woocommerce/README.md

@@ -1,39 +1,58 @@
-# Woocommerce Source
+# Woocommerce source connector
 
-This is the repository for the Woocommerce configuration based source connector.
-For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/sources/woocommerce).
+
+This is the repository for the Woocommerce source connector, written in Python.
+For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.com/integrations/sources/woocommerce).
 
 ## Local development
 
-#### Create credentials
 
-**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/woocommerce)
+### Prerequisites
+* Python (~=3.9)
+* Poetry (~=1.7) - installation instructions [here](https://python-poetry.org/docs/#installation)
+
+
+### Installing the connector
+From this connector directory, run:
+```bash
+poetry install --with dev
+```
+
+
+### Create credentials
+**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.com/integrations/sources/woocommerce)
 to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_woocommerce/spec.yaml` file.
 Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
-See `integration_tests/sample_config.json` for a sample config file.
+See `sample_files/sample_config.json` for a sample config file.
 
-**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source woocommerce test creds`
-and place them into `secrets/config.json`.
 
-### Locally running the connector docker image
+### Locally running the connector
+```
+poetry run source-woocommerce spec
+poetry run source-woocommerce check --config secrets/config.json
+poetry run source-woocommerce discover --config secrets/config.json
+poetry run source-woocommerce read --config secrets/config.json --catalog sample_files/configured_catalog.json
+```
 
-#### Build
 
-**Via [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md) (recommended):**
+### Running unit tests
+To run unit tests locally, from the connector directory run:
+```
+poetry run pytest unit_tests
+```
+
+### Building the docker image
+1. Install [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md)
+2. Run the following command to build the docker image:
 
 ```bash
 airbyte-ci connectors --name=source-woocommerce build
 ```
 
-An image will be built with the tag `airbyte/source-woocommerce:dev`.
+An image will be available on your host with the tag `airbyte/source-woocommerce:dev`.
 
-**Via `docker build`:**
 
-```bash
-docker build -t airbyte/source-woocommerce:dev .
-```
-
-#### Run
+### Running as a docker container
 
 Then run any of the connector commands as follows:
 
@@ -44,35 +63,41 @@ docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-woocommerce:dev discov
 docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-woocommerce:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
 ```
 
+### Running our CI test suite
+
 ## Testing
 
+
 You can run our full test suite locally using [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md):
 
 ```bash
 airbyte-ci connectors --name=source-woocommerce test
 ```
 
 ### Customizing acceptance Tests
-
-Customize `acceptance-test-config.yml` file to configure tests. See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) for more information.
+Customize `acceptance-test-config.yml` file to configure acceptance tests. See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) for more information.
 If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
 
-## Dependency Management
-
-All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
-We split dependencies between two groups, dependencies that are:
+### Dependency Management
+All of your dependencies should be managed via Poetry. 
+To add a new dependency, run:
+```bash
+poetry add <package-name>
+```
 
-- required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
-- required for the testing need to go to `TEST_REQUIREMENTS` list
+Please commit the changes to `pyproject.toml` and `poetry.lock` files.
 
-### Publishing a new version of the connector
+## Publishing a new version of the connector
 
 You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
 
 1. Make sure your changes are passing our test suite: `airbyte-ci connectors --name=source-woocommerce test`
-2. Bump the connector version in `metadata.yaml`: increment the `dockerImageTag` value. Please follow [semantic versioning for connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors).
+2. Bump the connector version (please follow [semantic versioning for connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors)): 
+    - bump the `dockerImageTag` value in in `metadata.yaml`
+    - bump the `version` value in `pyproject.toml`
 3. Make sure the `metadata.yaml` content is up to date.
-4. Make the connector documentation and its changelog is up to date (`docs/integrations/sources/woocommerce.md`).
+4. Make sure the connector documentation and its changelog is up to date (`docs/integrations/sources/woocommerce.md`).
 5. Create a Pull Request: use [our PR naming conventions](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#pull-request-title-convention).
 6. Pat yourself on the back for being an awesome contributor.
 7. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
+8. Once your PR is merged, the new version of the connector will be automatically published to Docker Hub and our connector registry.

airbyte-integrations/connectors/source-woocommerce/metadata.yaml

@@ -5,26 +5,28 @@ data:
   allowedHosts:
     hosts:
       - ${domain}
+  connectorBuildOptions:
+    baseImage: docker.io/airbyte/python-connector-base:1.2.0@sha256:c22a9d97464b69d6ef01898edf3f8612dc11614f05a84984451dde195f337db9
   connectorSubtype: api
   connectorType: source
   definitionId: 2a2552ca-9f78-4c1c-9eb7-4d0dc66d72df
-  dockerImageTag: 0.2.3
+  dockerImageTag: 0.2.7
   dockerRepository: airbyte/source-woocommerce
   documentationUrl: https://docs.airbyte.com/integrations/sources/woocommerce
   githubIssueLabel: source-woocommerce
   icon: woocommerce.svg
   license: MIT
   name: WooCommerce
-  remoteRegistries:
-    pypi:
-      enabled: true
-      packageName: airbyte-source-woocommerce
   registries:
     cloud:
       enabled: true
     oss:
       enabled: true
   releaseStage: beta
+  remoteRegistries:
+    pypi:
+      enabled: true
+      packageName: airbyte-source-woocommerce
   supportLevel: community
   tags:
     - language:python