Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Datastax Astra #34052

Closed
wants to merge 3 commits into from
Closed

Conversation

anomnaco
Copy link
Contributor

@anomnaco anomnaco commented Jan 9, 2024

Creating a source connector to read data from Datastax Astra's new JSON API. Requires python cdk because of the need to dynamically generate JSONSchema for tables since the JSON API is a document store and can have arbitrary schema.

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 9:02pm

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2024

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/astra labels Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@anomnaco anomnaco changed the title 🎉 New Destination: Datastax Astra 🎉 New Source: Datastax Astra Jan 9, 2024
@hc33brackles
Copy link

@flash1293 - we have updated this PR to reflect the changes you suggested on the Airbyte Destination PR you've been reviewing for us.

@marcosmarxm
Copy link
Member

Hello @anomnaco thanks for the contribution! I'm going to review during the week, as this been a full custom source will need some time to learn about how datastax works to make sure the implementation is following the recommended guidelines.

@hc33brackles
Copy link

Hi @marcosmarxm - for a little extra context here, this AstraDB source is a managed Cassandra provider - quite similar to the source you have for Apache Cassandra in function. Apologies if this is already info you have :-)

@marcosmarxm
Copy link
Member

Hi @marcosmarxm - for a little extra context here, this AstraDB source is a managed Cassandra provider - quite similar to the source you have for Apache Cassandra in function. Apologies if this is already info you have :-)

Thanks for the info, Cassandra is a destination using the Java JDBC base class.

@natikgadzhi
Copy link
Contributor

@aaronsteers we have astra already, right? Cool to close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

6 participants